Re: [PATCH v2 0/7] thread lazy_init_name_hash

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Mar 24, 2017, 12:39 UTC
Message-ID: <5f29c3d9-0de5-385e-fda1-fb4380c7bc17@jeffhostetler.com>
In-Reply-To: <xmqqh92jev8d.fsf@gitster.mtv.corp.google.com>

On 3/23/2017 1:52 PM, Junio C Hamano wrote:

> The API document update in 4/7 is a nice addition and it comes at
> the right spot in the series, just after API enhancement is done.  I
> gave a quick reading on it twice, and all looked reasonable.  Nicely
> done.

Thanks.

Show 7 quoted lines

> I queued the sparse things Ramsay pointed out in the form of
> "SQUASH???" immediately that follows your original patch while
> applying the series, so please check what I push out (when it
> happens) and if there is no further change needed, just tell me to
> actually squash them in, if you think these SQUASH??? patches are
> good.  That way we do not have to have another reroll only to fix
> these up ;-)

The squashes look fine.

WRT the assert() in name-hash.c, Stefan suggested converting it to an if-!-die form in an earlier message in this thread. I'm OK with that or with removing the assert completely.

Show 6 quoted lines

> I'll need to re-read "name-hash: perf improvement for lazy_init_name_hash"
> later again to convince myself, but during my initial read (from the
> last round) I didn't spot anything wrong there.
>
> Thanks.
>

Thanks, Jeff