Re: [PATCH] messages: avoid SHA-1 in end-user facing messages

From: Derrick Stolee <stolee@gmail.com>
Date: Aug 14, 2020, 12:21 UTC
Message-ID: <5e9805f4-81c0-39bc-463a-8c47872f6456@gmail.com>
In-Reply-To: <xmqqd03tzley.fsf@gitster.c.googlers.com>

On 8/14/2020 4:22 AM, Junio C Hamano wrote:

Show 11 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
> 
>> On Fri, Aug 14, 2020 at 12:45 AM Junio C Hamano <gitster@pobox.com> wrote:
>>>>> N_("Show blank SHA-1 for boundary commits (Default: off)")),
>>>>> N_("Blank object names of boundary commits (Default: off)")),
>>>
>>> You guessed my intention correctly.  By using the word "blank" as a
>>> verb (i.e. to fill the space, which should ordinarily contain
>>> something meaningful, with whitespace instead), I can shorten "Show
>>> blank" to compensate the lengthening of the message caused by
>>> replacing "SHA-1" with "object name".

Ah, the "whitespace, not all-zeroes" is something that I misunderstood. That makes a verb change valuable in this instance.

Show 10 quoted lines

>>> A better phrasing to replace it is of course welcome.
>>
>> Perhaps?
>>
>>     "suppress object names of boundary commits (default: off)"
> 
> I think we want a verb that not just means to "remove" but also to
> "replace with the same amount of whitespace so that the overall
> alignment is kept".  To "blank out" would mean exactly that; I do
> not know about "to suppress", though.

What about something as simple as:

	"Do not show object names of boundary commits (Default: off)"

While this doesn't imply that the object name positions are filled with whitespace, that is just a formatting concern.

Thanks, -Stolee