Re: [PATCH] git-send-email: Add a --cc-nobody option

From: Alex Unleashed <unledev@gmail.com>
Date: Sep 18, 2007, 12:50 UTC
Message-ID: <5e4707340709180550w3211e95fqd9fd648aab8ce78a@mail.gmail.com>
In-Reply-To: <11901157221792-git-send-email-felipebalbi@users.sourceforge.net>

On 9/18/07, felipebalbi@users.sourceforge.net <felipebalbi@users.sourceforge.net> wrote:

Show 6 quoted lines

> From: Felipe Balbi <felipe.lima@indt.org.br>
>
> This patch adds a --cc-nobody option to avoid sending emails
> to everybody but the ones listed by --to option.
>
> Signed-off-by: Felipe Balbi <felipe.lima@indt.org.br>

I wrote a similar patch a couple months ago, but they differ slightly, maybe the code has changed somewhat: http://marc.info/?l=git&m=118200193310898&w=2

--cc-nobody sounds better to me.

Show 11 quoted lines

>                                 } elsif (/^(Cc|From):\s+(.*)$/) {
> -                                       if (unquote_rfc2047($2) eq $sender) {
> -                                               next if ($suppress_from);
> +                                       if (unquote_rfc2047($2)) {
> +                                               next if ($cc_nobody);
> +                                       }
> +                                       elsif (unquote_rfc2047($2) eq $sender) {
> +                                               next if ($suppress_from|$cc_nobody);
>                                         }
>                                         elsif ($1 eq 'From') {
>                                                 $author = unquote_rfc2047($2);

Here you could probably skip the whole branch if you check $cc_nobody first of all.

Show 6 quoted lines

> @@ -707,7 +715,7 @@ foreach my $t (@files) {
>                         }
>                 } else {
>                         $message .=  $_;
> -                       if (/^(Signed-off-by|Cc): (.*)$/i && $signed_off_cc) {
> +                       if (/^(Signed-off-by|Cc): (.*)$/i && $signed_off_cc && !$cc_nobody) {

Minor, but almost the same here.

Alex