Re: [PATCH 1/2] t5403: Refactor

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Dec 29, 2018, 03:06 UTC
Message-ID: <5d3609cd-c934-fd3a-437a-30c6db930093@ramsayjones.plus.com>
In-Reply-To: <xmqqmuopl1qz.fsf@gitster-ct.c.googlers.com>

On 28/12/2018 22:34, Junio C Hamano wrote:

> orgads@gmail.com writes:
> 
>> Subject: Re: [PATCH 1/2] t5403: Refactor
>

[snip]

Show 14 quoted lines

>>  if test "$(git config --bool core.filemode)" = true; then
> 
> This is a tangent but this conditional came from an ancient d42ec126
> ("disable post-checkout test on Cygwin", 2009-03-17) that says
> 
>     disable post-checkout test on Cygwin
>     
>     It is broken because of the tricks we have to play with
>     lstat to get the bearable perfomance out of the call.
>     Sadly, it disables access to Cygwin's executable attribute,
>     which Windows filesystems do not have at all.
> 
> I wonder if this is still relevant these days (Cc'ed Ramsay for
> input).

Ah, no, the 'tricks we have to play with lstat' mentioned in that commit message are long gone! ;-) If you remove that conditional, then the test passes just fine.

ATB, Ramsay Jones