Re: [PATCH 2/3] diff_flush_patch_id: stop returning error result
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Sep 8, 2016, 00:51 UTC
- Message-ID
- <5c4276ad-19ed-1481-41cf-3d506ef9c7c6@ramsayjones.plus.com>
- In-Reply-To
- <20160907220409.oowxymhvkof2xsk5@sigill.intra.peff.net>
On 07/09/16 23:04, Jeff King wrote:
Show 5 quoted lines
> All of our errors come from diff_get_patch_id(), which has
> exactly three error conditions. The first is an internal
> assertion, which should be a die("BUG") in the first place.
>
> The other two are caused by an inability to two diff blobs,^^^^^^^^^^^^^^^^^ Huh? ... to diff two blobs?
ATB, Ramsay Jones