git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/2] rebase: skip branch symref aliases

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Jul 23, 2026, 18:58 UTC
Message-ID
<5bece313-6ffb-450b-add1-29652b64de10@gmail.com>
In-Reply-To
<b9a01e9141d580606527cb1a658c7c72710fb013.1784708107.git.gitgitgadget@gmail.com>
On 22/07/2026 09:15, Son Luong Ngoc via GitGitGadget wrote:
Show 24 quoted lines
> From: Son Luong Ngoc <sluongng@gmail.com>
> 
> git rebase --update-refs can finish rewriting the current branch and
> then fail while updating a local branch that is a symbolic ref. This can
> happen during a default-branch rename where refs/heads/main points at
> refs/heads/master while users migrate.
> 
> The problem is a partially applied ref update: the main rebase has
> already succeeded when the later ref update fails.
> 
> The sequencer queues updates from local branch decorations. Commit
> 106b6885c7 (rebase: ignore non-branch update-refs) filters out
> decorations such as HEAD and tags. A branch symref is still a local
> branch decoration, but refs_update_ref() dereferences it, so an alias to
> another branch duplicates the concrete branch update.
> 
> Resolve local branch decorations before queuing them. Skip symrefs whose
> targets are under refs/heads/ so that only the concrete branch update is
> queued. Keep an owned copy of the resolved HEAD and skip the current
> branch before checked-out handling so later ref resolution cannot change
> the comparison.
> 
> This prevents a successful rebase from being followed by a failed,
> partially applied ref update while preserving each alias as a symref.

Thanks for re-rolling I'm pretty sure the logic is sound now but I'm a bit confused by a couple of things - see my comments below.

Show 47 quoted lines
> Signed-off-by: Son Luong Ngoc <sluongng@gmail.com>
> ---
>   sequencer.c                   | 44 +++++++++++++++++++++++++----------
>   t/t3400-rebase.sh             |  2 +-
>   t/t3404-rebase-interactive.sh | 16 +++++++++++++
>   3 files changed, 49 insertions(+), 13 deletions(-)
> 
> diff --git a/sequencer.c b/sequencer.c
> index 1355a99a09..63aba60a08 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -6465,32 +6465,50 @@ static int add_decorations_to_list(const struct commit *commit,
>   				   struct todo_add_branch_context *ctx)
>   {
>   	const struct name_decoration *decoration = get_name_decoration(&commit->object);
> -	const char *head_ref = refs_resolve_ref_unsafe(get_main_ref_store(the_repository),
> -						       "HEAD",
> -						       RESOLVE_REF_READING,
> -						       NULL,
> -						       NULL);
> +	struct ref_store *refs = get_main_ref_store(the_repository);
> +	char *head_ref = refs_resolve_refdup(refs, "HEAD",
> +					     RESOLVE_REF_READING,
> +					     NULL, NULL);
>   
>   	while (decoration) {
>   		struct todo_item *item;
>   		const char *path;
> +		char *resolved_ref;
> +		int flags = 0;
>   		size_t base_offset = ctx->buf->len;
>   
>   		/*
> -		 * If the branch is the current HEAD, then it will be
> -		 * updated by the default rebase behavior.
> -		 * Exclude it from the list of refs to update,
> -		 * as well as any non-branch decorations.
>   		 * Non-branch decorations may be present if the pretty format
>   		 * includes "%d", which would have loaded all refs
>   		 * into the global decoration table.
>   		 */
> -		if ((head_ref && !strcmp(head_ref, decoration->name)) ||
> -		    (decoration->type != DECORATION_REF_LOCAL)) {
> +		if (decoration->type != DECORATION_REF_LOCAL) {
> +			decoration = decoration->next;
> +			continue;
> +		}

It would be nice to have a comment here explaining what we're doing. Also I don't think we need to copy the refname so it would be more efficient to use refs_resolve_ref_unsafe().

Show 9 quoted lines
> +		resolved_ref = refs_resolve_refdup(refs, decoration->name,
> +						      RESOLVE_REF_READING,
> +						      NULL, &flags);
> +		if (resolved_ref && (flags & REF_ISSYMREF) &&
> +		    starts_with(resolved_ref, "refs/heads/")) {
> +			free(resolved_ref);
> +			decoration = decoration->next;
> +			continue;
> +		}
We skip any symbolic refs that point to another branch which is good.
Show 9 quoted lines
> +		/*
> +		 * If the branch is the current HEAD, then it will be
> +		 * updated by the default rebase behavior.
> +		 */
> +		if (head_ref && !strcmp(head_ref, decoration->name)) {
> +			free(resolved_ref);
>   			decoration = decoration->next;
>   			continue;
>   		}

Then we check to see if the decoration matches HEAD which we used to do above - I'm not clear why we have moved this check.

> +		path = branch_checked_out(decoration->name);
> +
This belongs in the next patch I think.
Show 5 quoted lines
> diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh
> index e62e07b894..1a02f6546b 100755
> --- a/t/t3400-rebase.sh
> +++ b/t/t3400-rebase.sh
> @@ -471,7 +471,7 @@ test_expect_success 'git rebase --update-ref with core.commentChar and branch on
Adding an extra context line shows
	git checkout topic2>   	GIT_SEQUENCE_EDITOR="cat >actual" git -c 
core.commentChar=% \
>   		 rebase -i --update-refs base &&
>   	test_grep "% Ref refs/heads/wt-topic checked out at" actual &&
> -	test_grep "% Ref refs/heads/topic2 checked out at" actual
> +	test_grep ! "% Ref refs/heads/topic2 checked out at" actual

As topic2 is checked out in the worktree where the rebase is running why did this line appear before?

Show 9 quoted lines
> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
> index e64816770a..11afa8be56 100755
> --- a/t/t3404-rebase-interactive.sh
> +++ b/t/t3404-rebase-interactive.sh
> @@ -1975,15 +1975,23 @@ test_expect_success '--update-refs ignores non-branch decorations' '
>   	) &&
>   	grep ^update-ref todo >actual &&
>   	test_write_lines "update-ref refs/heads/no-conflict-branch" >expect &&
> +	test_grep ! "^# Ref refs/heads/update-refs checked out" todo &&

Lets move this line below test_cmp so we keep that line next to the ones that create the files that are being compared. Is this another case where we used to add this comment and no longer do so?

Show 33 quoted lines
>   	test_cmp expect actual
>   '
>   
>   test_expect_success '--update-refs updates refs correctly' '
> +	test_when_finished "
> +		test_might_fail git symbolic-ref -d refs/heads/no-conflict-branch-alias &&
> +		test_might_fail git symbolic-ref -d refs/heads/second-alias
> +	" &&
>   	git checkout -B update-refs no-conflict-branch &&
>   	git branch -f base HEAD~4 &&
>   	git branch -f first HEAD~3 &&
>   	git branch -f second HEAD~3 &&
>   	git branch -f third HEAD~1 &&
> +	git symbolic-ref refs/heads/no-conflict-branch-alias \
> +		refs/heads/no-conflict-branch &&
> +	git symbolic-ref refs/heads/second-alias refs/heads/second &&
>   	test_commit extra2 fileX &&
>   	git commit --amend --fixup=L &&
>   
> @@ -1991,8 +1999,16 @@ test_expect_success '--update-refs updates refs correctly' '
>   
>   	test_cmp_rev HEAD~3 refs/heads/first &&
>   	test_cmp_rev HEAD~3 refs/heads/second &&
> +	test_cmp_rev HEAD~3 refs/heads/second-alias &&
>   	test_cmp_rev HEAD~1 refs/heads/third &&
>   	test_cmp_rev HEAD refs/heads/no-conflict-branch &&
> +	test_cmp_rev HEAD refs/heads/no-conflict-branch-alias &&
> +	test_write_lines refs/heads/no-conflict-branch >expect &&
> +	git symbolic-ref refs/heads/no-conflict-branch-alias >actual &&
> +	test_cmp expect actual &&
> +	test_write_lines refs/heads/second >expect &&
> +	git symbolic-ref refs/heads/second-alias >actual &&
> +	test_cmp expect actual &&

This looks good - we check that "rebase --update-refs" succeeds withh branches that are symrefs and also that those refs are untouched by the rebase.

Thanks
Phillip
>   	q_to_tab >expect <<-\EOF &&
>   	Successfully rebased and updated refs/heads/update-refs.
Previous: Son Luong Ngoc via GitGitGadgetNext: Phillip Wood
Message 13 of 25 in “rebase: handle --update-refs branch symrefs”
  1. 0/2 rebase: handle --update-refs branch symrefsSon Luong Ngoc via GitGitGadget, May 28, 2026
  2. 1/2 t3404: add failing branch symref testSon Luong Ngoc via GitGitGadget, May 28, 2026
  3. Phillip WoodJun 1, 2026
  4. 2/2 rebase: skip branch symref aliasesSon Luong Ngoc via GitGitGadget, May 28, 2026
  5. Kristoffer HaugsbakkMay 28, 2026
  6. Phillip WoodJun 1, 2026
  7. Junio C HamanoMay 28, 2026
  8. rebase: skip branch symref aliasesSon Luong Ngoc via GitGitGadget, Jun 3, 2026
  9. Phillip WoodJun 4, 2026
  10. Son Luong NgocJul 22, 2026
  11. 0/2 rebase: handle --update-refs branch symrefsSon Luong Ngoc via GitGitGadget, Jul 22, 2026
  12. 1/2 rebase: skip branch symref aliasesSon Luong Ngoc via GitGitGadget, Jul 22, 2026
  13. Phillip WoodJul 23, 2026
  14. Phillip WoodJul 24, 2026
  15. Erik Cervin-EdinJul 25, 2026
  16. Junio C HamanoJul 26, 2026
  17. Phillip WoodJul 28, 2026
  18. Junio C HamanoJul 28, 2026
  19. Phillip WoodJul 29, 2026
  20. Junio C HamanoJul 29, 2026
  21. Phillip WoodJul 30, 2026
  22. Junio C HamanoAug 6, 2026
  23. Phillip WoodAug 7, 2026
  24. 2/2 rebase: guard non-branch symref targetsSon Luong Ngoc via GitGitGadget, Jul 22, 2026
  25. Phillip WoodAug 7, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.