git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] Clean: Remove superfluous strbuf 'docs'

From
Michael Witten <mfwitten@gmail.com>
Date
Feb 15, 2011, 23:12 UTC
Message-ID
<5bddd028-bf38-46b9-a189-bdb09038dfdd-mfwitten@gmail.com>
In-Reply-To
<1fbceaa8-398c-44ec-8833-a03e4cca6805-mfwitten@gmail.com>
Signed-off-by: Michael Witten <mfwitten@gmail.com>
---
 strbuf.h |   37 +------------------------------------
 1 files changed, 1 insertions(+), 36 deletions(-)
diff --git a/strbuf.h b/strbuf.h
index f722331..07060ce 100644
--- a/strbuf.h
+++ b/strbuf.h
@@ -1,42 +1,7 @@
 #ifndef STRBUF_H
 #define STRBUF_H
 
-/*
- * Strbuf's can be use in many ways: as a byte array, or to store arbitrary
- * long, overflow safe strings.
- *
- * Strbufs has some invariants that are very important to keep in mind:
- *
- * 1. the ->buf member is always malloc-ed, hence strbuf's can be used to
- *    build complex strings/buffers whose final size isn't easily known.
- *
- *    It is NOT legal to copy the ->buf pointer away.
- *    `strbuf_detach' is the operation that detaches a buffer from its shell
- *    while keeping the shell valid wrt its invariants.
- *
- * 2. the ->buf member is a byte array that has at least ->len + 1 bytes
- *    allocated. The extra byte is used to store a '\0', allowing the ->buf
- *    member to be a valid C-string. Every strbuf function ensures this
- *    invariant is preserved.
- *
- *    Note that it is OK to "play" with the buffer directly if you work it
- *    that way:
- *
- *    strbuf_grow(sb, SOME_SIZE);
- *       ... Here, the memory array starting at sb->buf, and of length
- *       ... strbuf_avail(sb) is all yours, and you are sure that
- *       ... strbuf_avail(sb) is at least SOME_SIZE.
- *    strbuf_setlen(sb, sb->len + SOME_OTHER_SIZE);
- *
- *    Of course, SOME_OTHER_SIZE must be smaller or equal to strbuf_avail(sb).
- *
- *    Doing so is safe, though if it has to be done in many places, adding the
- *    missing API to the strbuf module is the way to go.
- *
- *    XXX: do _not_ assume that the area that is yours is of size ->alloc - 1
- *         even if it's true in the current implementation. Alloc is somehow a
- *         "private" member that should not be messed with.
- */
+/* See Documentation/technical/api-strbuf.txt */
 
 #include <assert.h>
 
-- 
1.7.4.18.g68fe8
Previous: Michael WittenNext: Michael Witten
Message 3 of 8 in “Clean: Remove useless parameters from both get_commit_info() functions”
  1. 4/4 Clean: Remove useless parameters from both get_commit_info() functionsMichael Witten, Feb 11, 2011
  2. 0/4 Miscellaneous ImprovementsMichael Witten, Mar 30, 2011
  3. 2/4 Clean: Remove superfluous strbuf 'docs'Michael Witten, Feb 15, 2011
  4. 1/4 Typos: t/READMEMichael Witten, Feb 22, 2011
  5. Junio C HamanoMar 30, 2011
  6. Michael WittenMar 30, 2011
  7. 3/4 Clean: Remove unnecessary `\' (line continuation)Michael Witten, Mar 2, 2011
  8. Junio C HamanoMar 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.