git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t7400: add BSLASHPSPEC prerequisite to 'add with \\ in path'

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Apr 28, 2017, 01:53 UTC
Message-ID
<5b8e0f3a-0b64-1384-d830-5b65a43e44c4@ramsayjones.plus.com>

Commit cf9e55f494 ("submodule: prevent backslash expantion in submodule names", 07-04-2017) added a test which creates a git repository with some backslash characters in the name. This test cannot work on windows, since the backslash is used as the directory separator. In order to suppress this test on cygwin, MinGW and Git for Windows, we add the BSLASHPSPEC prerequisite. (see also commits 6fd1106aa4 and c51c0da222).

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Junio,

I built v2.13.0-rc1 and ran the test-suite on cygwin this evening and had an additional failure, over and above the failures reported for v2.13.0-rc0, namely t7400.20. This patch elides that test for cygwin (and MinGW and GfW, so it would be good to hear success reports from both Johannes).

Thanks!

ATB, Ramsay Jones

 t/t7400-submodule-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
index c2706fe47..0d83153f3 100755
--- a/t/t7400-submodule-basic.sh
+++ b/t/t7400-submodule-basic.sh
@@ -273,7 +273,7 @@ test_expect_success 'submodule add with ./, /.. and // in path' '
 	test_cmp empty untracked
 '
 
-test_expect_success 'submodule add with \\ in path' '
+test_expect_success BSLASHPSPEC 'submodule add with \\ in path' '
 	test_when_finished "rm -rf parent sub\\with\\backslash" &&
 
 	# Initialize a repo with a backslash in its name
-- 
2.12.0
Next: Junio C Hamano
Message 1 of 9 in “t7400: add BSLASHPSPEC prerequisite to 'add with \\ in path'”
  1. t7400: add BSLASHPSPEC prerequisite to 'add with \\ in path'Ramsay Jones, Apr 28, 2017
  2. Junio C HamanoApr 28, 2017
  3. Johannes SixtApr 28, 2017
  4. Ramsay JonesApr 29, 2017
  5. Johannes SixtApr 29, 2017
  6. Johannes SchindelinApr 29, 2017
  7. Ramsay JonesApr 30, 2017
  8. Johannes SchindelinMay 1, 2017
  9. Ramsay JonesApr 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.