git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] test-list-objects: mark file-local symbols as static

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Oct 3, 2017, 21:51 UTC
Message-ID
<5b3d8899-d4c5-c145-7128-21c8aaa4f38f@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Derrick,

If you need to re-roll your 'ds/find-unique-abbrev-optim' branch, could you please squash this into the relevant patch (commit 3792c78ba0, "test-list-objects: list a subset of object ids", 01-10-2017).

Thanks!

ATB, Ramsay Jones

 t/helper/test-list-objects.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/t/helper/test-list-objects.c b/t/helper/test-list-objects.c
index 22bc9b4e6..5c5d3c03f 100644
--- a/t/helper/test-list-objects.c
+++ b/t/helper/test-list-objects.c
@@ -6,43 +6,43 @@ struct count {
 	int select_mod;
 };
 
-int count_loose(const struct object_id *oid,
-		const char *path,
-		void *data)
+static int count_loose(const struct object_id *oid,
+		       const char *path,
+		       void *data)
 {
 	((struct count*)data)->total++;
 	return 0;
 }
 
-int count_packed(const struct object_id *oid,
-		 struct packed_git *pack,
-		 uint32_t pos,
-		 void* data)
+static int count_packed(const struct object_id *oid,
+			struct packed_git *pack,
+			uint32_t pos,
+			void* data)
 {
 	((struct count*)data)->total++;
 	return 0;
 }
 
-void output(const struct object_id *oid,
-	    struct count *c)
+static void output(const struct object_id *oid,
+		   struct count *c)
 {
 	if (!(c->total % c->select_mod))
 		printf("%s\n", oid_to_hex(oid));
 	c->total--;
 }
 
-int output_loose(const struct object_id *oid,
-		 const char *path,
-		 void *data)
+static int output_loose(const struct object_id *oid,
+			const char *path,
+			void *data)
 {
 	output(oid, (struct count*)data);
 	return 0;
 }
 
-int output_packed(const struct object_id *oid,
-		  struct packed_git *pack,
-		  uint32_t pos,
-		  void* data)
+static int output_packed(const struct object_id *oid,
+			 struct packed_git *pack,
+			 uint32_t pos,
+			 void* data)
 {
 	output(oid, (struct count*)data);
 	return 0;
-- 
2.14.0
Next: Derrick Stolee
Message 1 of 2 in “test-list-objects: mark file-local symbols as static”
  1. test-list-objects: mark file-local symbols as staticRamsay Jones, Oct 3, 2017
  2. Derrick StoleeOct 4, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.