git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] refs.c: free duplicate entries in the ref array instead of leaking them

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Oct 8, 2011, 03:20 UTC
Message-ID
<5WORKOGzj9pUA6-WazYHWrx23BzZNuzssM-BrpbAt7jziy1qExfJm7by5NnJUMOk6ewCveYCPmzYGScMzowqtqJ8RZ9pZP6PRSU69BNSzr2gzdZ7nKtDsZyIEWyAD9p9GiIdHbxCa0M@cipher.nrlssc.navy.mil>
In-Reply-To
<3k7giKa3PkJZo51iAXivXCFEZpYY2WC3depjtuvksrCQPax7dSLVCXpMlqLxWtZfSp6P10yMhMg@cipher.nrlssc.navy.mil>
From: Brandon Casey <drafnel@gmail.com>
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
 refs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/refs.c b/refs.c
index cbc4c5d..df39297 100644
--- a/refs.c
+++ b/refs.c
@@ -94,6 +94,7 @@ static void sort_ref_array(struct ref_array *array)
 				die("Duplicated ref, and SHA1s don't match: %s",
 				    a->name);
 			warning("Duplicated ref: %s", a->name);
+			free(b);
 			continue;
 		}
 		i++;
-- 
1.7.7
Previous: Brandon Casey
Message 3 of 3 in “refs.c: ensure struct whose member may be passed to realloc is initialized”
  1. 1/3 refs.c: ensure struct whose member may be passed to realloc is initializedBrandon Casey, Oct 8, 2011
  2. 2/3 refs.c: abort ref search if ref array is emptyBrandon Casey, Oct 8, 2011
  3. 3/3 refs.c: free duplicate entries in the ref array instead of leaking themBrandon Casey, Oct 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.