git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Build Failure: GIT-GUI-VARS

From
Brian Gernhardt <benji@silverinsanity.com>
Date
May 11, 2007, 14:08 UTC
Message-ID
<5F2FFEA3-0D62-432D-98F7-8BE896937067@silverinsanity.com>
In-Reply-To
<7v8xbwgkia.fsf@assigned-by-dhcp.cox.net>
On May 10, 2007, at 10:30 PM, Junio C Hamano wrote:
> I do not either, and obviously does not reproduce for me.  Time
> for you to try "make -d" perhaps?

Sorry for the semi-coherent message. It started out as "we should fix this" and I ended up going "why is it broken", all a little too late at night. I'm also not used to debugging Makefiles.

And I figured it out (make -p actually was more useful than -d): It's another issue with doing things before including config.mak. My config.mak includes the "NO_TCLTK=y" line, which takes effect at Makefile:485. But gitk-wish is getting included in OTHER_PROGRAMS at Makefile:272. So gitk-wish gets included because NO_TCLTK isn't defined at that point, but all the other rules involving gitk don't get executed because they're after the NO_TCLTK definition.

I think we need to be including the config.mak much earlier in the Makefile as this is not the first time issues like this have come up for me. And they tend to be issues that only come up with specific configurations and are therefore harder to track down. Things I can see being an issue for people who put their options in config.mak:

149: ifeq ($(prefix),/usr) 224: ifdef WITH_P4IMPORT 271: ifndef NO_TCLTK # My issue today 279-285: ifndef {SHELL,PERL,PYTHON}_PATH

~~ Brian
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 5 in “Build Failure: GIT-GUI-VARS”
  1. Brian GernhardtMay 11, 2007
  2. Junio C HamanoMay 11, 2007
  3. Brian GernhardtMay 11, 2007
  4. Junio C HamanoMay 11, 2007
  5. Jeff KingMay 12, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.