git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: strbuf name conflict on Mac OS

From
Brian Gernhardt <benji@silverinsanity.com>
Date
Mar 31, 2009, 20:26 UTC
Message-ID
<5ECAAD78-F8D4-4F86-A16B-C8DF483771D6@silverinsanity.com>
In-Reply-To
<E5D92A5D-B2CC-44CE-B117-0BB88C0E663E@gmail.com>
On Mar 31, 2009, at 4:17 PM, Joshua Juran wrote:
Show 7 quoted lines
> Apple's OpenTransport.h from Universal Interfaces 3.4.2 defines its  
> own struct strbuf, with which git's collides.
>
> Since OpenTransport.h also defines some POSIX constants (such as  
> O_NONBLOCK) as enums, it's necessary to include OpenTransport.h from  
> fcntl.h (and other affected headers) so as to control the order in  
> which the definitions appear in the translation unit.

Just to be clear, this is related to your work on LAMP under Classic and not OS X, correct? If so, perhaps you need to create a compat/ classic_mac.h file that's included (when the correct #defines are seen) from git-compat-util.h in the manner of compat/ {cygwin,mingw}.h. I'm assuming that this naming conflict is not the only such you'll find and it's better to keep platform specific tweaks to a single place when possible.

~~ Brian
Previous: Joshua Juran
Message 5 of 5 in “strbuf name conflict on Mac OS”
  1. Joshua JuranMar 31, 2009
  2. Johannes SchindelinMar 31, 2009
  3. Jay SoffianMar 31, 2009
  4. Joshua JuranMar 31, 2009
  5. Brian GernhardtMar 31, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.