Re: [PATCH v5] git-p4: add config git-p4.pathEncoding

From: Lars Schneider <larsxschneider@gmail.com>
Date: Sep 3, 2015, 15:20 UTC
Message-ID: <5E77893F-8E13-4696-B7A6-46E10FE41989@gmail.com>
In-Reply-To: <983771583.1014619.1441268816360.JavaMail.zimbra@ensimag.grenoble-inp.fr>

On 03 Sep 2015, at 10:26, Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> wrote:

Show 14 quoted lines

> Hi Lars,
> 
> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>> +test_expect_success 'Clone repo containing iso8859-1 encoded paths with git-p4.pathEncoding' '
>> +
>> +        test_when_finished cleanup_git &&
>> +        (
>> +                cd "$git" &&
>> +                git init . &&
>> +                git config git-p4.pathEncoding iso8859-1 &&
> 
> Wouldn't 'test_config' be better here?
>

If I got Eric’s explanation right in "[PATCH v1] t9821: use test_config” then we should not use “test_config” here?

Thanks, Lars