Re: [PATCH] cocci: detect useless free(3) calls

From: Lars Schneider <larsxschneider@gmail.com>
Date: Feb 11, 2017, 19:31 UTC
Message-ID: <5DF3AA3E-90C6-443C-A22C-489CE2C89A51@gmail.com>
In-Reply-To: <7e10f934-f084-ceb4-00eb-b75cdb01886b@web.de>

Show 10 quoted lines

> On 11 Feb 2017, at 14:58, René Scharfe <l.s.r@web.de> wrote:
> 
> Add a semantic patch for removing checks that cause free(3) to only be
> called with a NULL pointer, as that must be a programming mistake.
> 
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> No cases are found in master or next, but 1d263b93 (bisect--helper:
> `bisect_next_check` & bisect_voc shell function in C) introduced four
> of them to pu.

Hi Rene,

how do you run these checks on the entire Git source? Do you run each semantic patch file on the source like this?

spatch --sp-file contrib/coccinelle/qsort.cocci --dir /path/to/git/git ... spatch --sp-file contrib/coccinelle/free.cocci --dir /path/to/git/git

How stable do you consider these checks? Would it make sense to run them as part of the Travis-CI build [1]?

Thanks, Lars

[1] https://travis-ci.org/git/git/branches