git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH] [RFC] Making use of bitmaps for thin objects

From
BMBen Maurer <bmaurer@fb.com>
Date
Jan 6, 2014, 22:14 UTC
Message-ID
<5CDDBDF2D36D9F43B9F5E99003F6A0D4466885EE@PRN-MBX02-1.TheFacebook.com>
In-Reply-To
<20140106215713.GA7133@sigill.intra.peff.net>
It looks like for my repo the size win wasn't as big (~10%). Is it possible that with the kernel test you got extremely lucky and there was some huge binary blob that thin packing turned into a tiny delta?
The repo I'm testing with here isn't a typical codebase -- it is used to store configuration information and it has very different update patterns than most codebases.
When you get a chance, it'd be handy if you could push an updated version of your change out to your public github repo. I'd like to see if folks here are interested in testing this more, and it'd be good to make sure we're testing the diff that is targeted for upstream.
Bitmap index, without thin packing:

Counting objects: 158825, done. Delta compression using up to 32 threads. Compressing objects: 100% (18113/18113), done. Writing objects: 100% (158825/158825), 89.87 MiB | 11.23 MiB/s, done. Total 158825 (delta 139493), reused 153076 (delta 135730) real 15.60 user 34.38 sys 2.99

Bitmap index, with thin packing:

Counting objects: 158825, done. Delta compression using up to 32 threads. Compressing objects: 100% (12364/12364), done. Writing objects: 100% (158825/158825), 81.35 MiB | 0 bytes/s, done. Total 158825 (delta 135730), reused 158825 (delta 141479) real 2.70 user 2.28 sys 0.65

________________________________________
From: Jeff King [peff@peff.net]
Sent: Monday, January 06, 2014 1:57 PM
To: Ben Maurer
Cc: git@vger.kernel.org
Subject: Re: [PATCH] [RFC] Making use of bitmaps for thin objects
On Mon, Jan 06, 2014 at 09:15:04PM +0000, Ben Maurer wrote:
Show 6 quoted lines
> > Let me know how this patch does for you. My testing has been fairly
> > limited so far.
>
> This patch looks like a much cleaner version :-). Works well for me,
> but my test setup may not be great since I didn't get any errors from
> completely ignoring the haves bitmap :-).

Great. Out of curiosity, can you show the before/after? The timings should be similar to what your patch produced, but I'm really curious to see how the pack size changes.

-Peff
Previous: Jeff KingNext: Jeff King
Message 10 of 11 in “[RFC] Making use of bitmaps for thin objects”
  1. [RFC] Making use of bitmaps for thin objectsBen Maurer, Dec 22, 2013
  2. Ben MaurerDec 22, 2013
  3. Jeff KingJan 6, 2014
  4. Junio C HamanoJan 6, 2014
  5. Jeff KingJan 6, 2014
  6. Jeff KingJan 6, 2014
  7. Jeff KingJan 6, 2014
  8. Ben MaurerJan 6, 2014
  9. Jeff KingJan 6, 2014
  10. Ben MaurerJan 6, 2014
  11. Jeff KingJan 7, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.