Re: [PATCH] sequencer: remove use of comment character

From: Tony Tung <tonytung@merly.org>
Date: Oct 31, 2023, 04:42 UTC
Message-ID: <5C268049-561B-4E1A-AD6A-493BCD4F2351@merly.org>
In-Reply-To: <xmqqa5rzadlh.fsf@gitster.g>

Show 14 quoted lines

> On Oct 30, 2023, at 4:35 PM, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Elijah Newren <newren@gmail.com> writes:
> 
>> I thought the point of the comment_line_char was so that commit
>> messages could have lines starting with '#'.  That rationale doesn't
>> apply to the TODO list generation or parsing, and I'm not sure if we
>> want to add the same complexity there.
> 
> Thanks for a healthy dose of sanity.  I noticed existing use of
> comment_line_char everywhere in sequencer.c and assumed we would
> want to be consistent, but you are right to point out that they are
> all about the COMMIT_EDITMSG kind of thing, and not about what
> appears in "sequencer/todo”.

I believe comment_line_char is being applied when the sequencer reads back the instructions, which is why I ran into this problem to begin with.

If the intent is not to apply it to the sequencer, then the bugfix is in the wrong place.

Thanks