git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: RFC: Enable delayed responses to Git clean/smudge filter requests

From
Lars Schneider <larsxschneider@gmail.com>
Date
Nov 15, 2016, 14:29 UTC
Message-ID
<5BC69AC1-5499-4F73-816A-D8786106D796@gmail.com>
In-Reply-To
<20161115010356.GA29602@starla>
Show 29 quoted lines
> On 15 Nov 2016, at 02:03, Eric Wong <e@80x24.org> wrote:
> 
> Lars Schneider <larsxschneider@gmail.com> wrote:
>> Hi,
>> 
>> Git always performs a clean/smudge filter on files in sequential order.
>> Sometimes a filter operation can take a noticeable amount of time. 
>> This blocks the entire Git process.
> 
> I have the same problem in many places which aren't git :>
> 
>> I would like to give a filter process the possibility to answer Git with
>> "I got your request, I am processing it, ask me for the result later!".
>> 
>> I see the following way to realize this:
>> 
>> In unpack-trees.c:check_updates() [1] we loop through the cache 
>> entries and "ask me later" could be an acceptable return value of the 
>> checkout_entry() call. The loop could run until all entries returned
>> success or error.
>> 
>> The filter machinery is triggered in various other places in Git and
>> all places that want to support "ask me later" would need to be patched 
>> accordingly.
> 
> That all sounds reasonable.
> 
> The filter itself would need to be aware of parallelism
> if it lives for multiple objects, right?
Correct. This way Git doesn't need to deal with threading...
Show 9 quoted lines
>> Do you think this could be a viable approach?
> 
> It'd probably require a bit of work, but yes, I think it's viable.
> 
> We already do this with curl_multi requests for parallel
> fetching from dumb HTTP servers, but that's driven by curl
> internals operating with a select/poll loop.
> 
> Perhaps the curl API could be a good example for doing this.
Thanks for the pointer!
>> Do you see a better way?
> 
> Nope, I prefer non-blocking state machines to threads for
> debuggability and determinism.
Agreed!
> Anyways, I'll plan on doing something similar (in Perl) with the
> synchronous parts of public-inbox which relies on "cat-file --batch"
> at some point... (my rotational disks are sloooooooow :<)

That sounds interesting! What changes to you have in mind for "cat-file --batch"? We are thinking about performance improvements in that area, too. I would be happy to help reviewing your patches!

Thanks a lot for your RFC feedback, Lars

Previous: Eric WongNext: Junio C Hamano
Message 3 of 16 in “RFC: Enable delayed responses to Git clean/smudge filter requests”
  1. Lars SchneiderNov 14, 2016
  2. Eric WongNov 15, 2016
  3. Lars SchneiderNov 15, 2016
  4. Junio C HamanoNov 15, 2016
  5. Lars SchneiderNov 16, 2016
  6. Junio C HamanoNov 16, 2016
  7. Lars SchneiderNov 16, 2016
  8. Junio C HamanoNov 16, 2016
  9. Jakub NarębskiNov 16, 2016
  10. Junio C HamanoNov 16, 2016
  11. Lars SchneiderNov 17, 2016
  12. Lars SchneiderNov 24, 2016
  13. Junio C HamanoNov 28, 2016
  14. Eric WongNov 15, 2016
  15. Stefan BellerJan 9, 2017
  16. Lars SchneiderJan 11, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.