Re: [PATCH] branch: clarify <oldbranch> and <newbranch> terms further

From: Dragan Simic <dsimic@manjaro.org>
Date: Feb 6, 2024, 18:37 UTC
Message-ID: <59ee31e27daff7f9e9f6c4a3bb81086f@manjaro.org>
In-Reply-To: <xmqqle7xih0s.fsf@gitster.g>

On 2024-02-06 19:28, Junio C Hamano wrote:

Show 11 quoted lines

> Dragan Simic <dsimic@manjaro.org> writes:
>>> I think I laid all this out and more in a separate message.
>>> https://lore.kernel.org/git/xmqq8r4zln08.fsf@gitster.g/
>> 
>> I agree about this as well, but that will perhaps be handled in some
>> separate patch for the git-branch(1) man page.
> 
> If you truly agree with the longer term plan, which includes removal
> of the bullet points your patch updates, then reviewing further on
> that patch becomes a waste of time in the larger picture, doesn't
> it?

Hmm, it doesn't seem like a waste of time and effort to me, because the first patch would move/add the descriptions of the <oldbranch> and <newbranch> arguments to the descriptions of the branch copy and rename operations in the "Options" section.

This needs to be done anyway, if you agree. The following patch would either dissolve as many sentences from the "Description" section into the "Options" section, or have those sentences converted into some kind of more readable prose.

I hope you agree.

> "Will be deferred to some later time, let's take this small update
> as-is" has already been said back then.  Let's not do that again
> this time.

Oh, I've also heard that too many times, and I also know where such an approach usually leads. Nowhere. :)