git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] gitk: fix text wrapping preferences for unthemed tk

From
CGChristoph Sommer via GitGitGadget <gitgitgadget@gmail.com>
Date
Apr 28, 2025, 15:56 UTC
Message-ID
<59a6d8831a75f793aae087bbffa9325f09af246a.1745855773.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1909.git.1745855773.gitgitgadget@gmail.com>
From: Christoph Sommer <sommer@cms-labs.org>
Use a widget factory that works for both plain Tk and themed Tk.
Signed-off-by: Christoph Sommer <sommer@cms-labs.org>
---
 gitk-git/gitk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index bc9efa18566..8cb17f39d41 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -11767,13 +11767,11 @@ proc prefspage_general {notebook} {
     grid x $page.tabstopl $page.tabstop -sticky w
 
     ${NS}::label $page.wrapcommentl -text [mc "Wrap comment text"]
-    ${NS}::combobox $page.wrapcomment -values {none char word} -state readonly \
-        -textvariable wrapcomment
+    makedroplist $page.wrapcomment wrapcomment "none" "char" "word"
     grid x $page.wrapcommentl $page.wrapcomment -sticky w
 
     ${NS}::label $page.wrapdefaultl -text [mc "Wrap other text"]
-    ${NS}::combobox $page.wrapdefault -values {none char word} -state readonly \
-        -textvariable wrapdefault
+    makedroplist $page.wrapdefault wrapdefault "none" "char" "word"
     grid x $page.wrapdefaultl $page.wrapdefault -sticky w
 
     ${NS}::checkbutton $page.ntag -text [mc "Display nearby tags/heads"] \
-- 
gitgitgadget
Previous: Christoph Sommer via GitGitGadgetNext: Christoph Sommer via GitGitGadget
Message 2 of 4 in “gitk: small quality of life improvements for themed Tk”
  1. 0/3 gitk: small quality of life improvements for themed TkChristoph Sommer via GitGitGadget, Apr 28, 2025
  2. 1/3 gitk: fix text wrapping preferences for unthemed tkChristoph Sommer via GitGitGadget, Apr 28, 2025
  3. 3/3 gitk: on themed tk, use uicolor to draw a sash between panesChristoph Sommer via GitGitGadget, Apr 28, 2025
  4. 2/3 gitk: do not set fg/bg color scheme for themed TkChristoph Sommer via GitGitGadget, Apr 28, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.