Re: [PATCH 09/11] config-batch: add 'set' v1 command
- From
Jean-Noël Avila <jn.avila@free.fr>
- Date
- Feb 6, 2026, 05:04 UTC
- Message-ID
- <5861406e-0ac7-4b96-9bde-cd3860ad5c4d@free.fr>
- In-Reply-To
- <fdeef536f649bec811e8335d1c7151be8e352ff0.1770214803.git.gitgitgadget@gmail.com>
Le 04/02/2026 à 15:20, Derrick Stolee via GitGitGadget a écrit :
Show 25 quoted lines
> From: Derrick Stolee <stolee@gmail.com> > > This new command is intended for single-value assignments to a specific > chosen scope. More complicated versions of the 'git config set' command > will be incorporated into future commands. > > Signed-off-by: Derrick Stolee <stolee@gmail.com> > --- > Documentation/git-config-batch.adoc | 24 ++++++++ > builtin/config-batch.c | 71 ++++++++++++++++++++++ > config.c | 27 +++++++++ > config.h | 3 + > t/t1312-config-batch.sh | 94 ++++++++++++++++++++++++++++- > 5 files changed, 217 insertions(+), 2 deletions(-) > > diff --git a/Documentation/git-config-batch.adoc b/Documentation/git-config-batch.adoc > index 3c9a3bb763..feec85c4ef 100644 > --- a/Documentation/git-config-batch.adoc > +++ b/Documentation/git-config-batch.adoc > @@ -111,6 +111,30 @@ get 1 missing <key> [<value-pattern>|<value>] > where `<value-pattern>` or `<value>` is only supplied if provided in > the command. > > +`set` version 1:: > + The `set` command writes a single key-value pair to a config
Please use direct imperative form.
Show 10 quoted lines
> + file. It specifies which file by a `<scope>` parameter from > + among `system`, `global`, `local`, and `worktree`. The `<key>` > + is the next positional argument. The remaining data in the line > + is provided as the `<value>` to assign the config. > ++ > +------------ > +set 1 <scope> <key> <value> > +------------ > ++ > +These uses will match the behavior of `git config --set --<scope> <key>
This "--<scope>" form is new in the synopsis grammar. Would we just cite all alternatives or use a "normal" placeholder _<scope>_ ?
Show 12 quoted lines
> +<value>`. Note that replacing all values with the `--all` option or > +matching specific value patterns are not supported by this command. > ++ > +The response of these commands will include a `success` message if the > +value is written as expected or `failed` if an unexpected failure > +occurs: > ++ > +------------ > +set 1 success <scope> <key> <value> > +set 1 failed <scope> <key> <value> > +------------ > +
Please use synopsis style block for these too.
> NUL-Terminated Format > ~~~~~~~~~~~~~~~~~~~~~ >