[PATCH] gitweb: fix base url set if PATH_INFO is used, add a / at the end.
- From
- Daniel Abrecht <git-git@nodmarc.danielabrecht.ch>
- Date
- Feb 3, 2023, 21:42 UTC
- Message-ID
- <585496b18c853140144c3e7ae13c0124@abrecht.li>
In HTML, if there is a base tag like `<base href="/a/b">`, a relative URL like `c/d` will be resolved by the browser as `a/c/d` and not as `a/b/c/d`. But with a base tag like `<base href="/a/b/">` it will result in `a/b/c/d`. So by adding a slash there, the browser should now search the files at the correct location.
Signed-off-by: Daniel Abrecht <public@danielabrecht.ch> --- gitweb/gitweb.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index e66eb3d9ba..acb2cce5f6 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4217,7 +4217,7 @@ sub git_header_html { # the stylesheet, favicon etc urls won't work correctly with path_info # unless we set the appropriate base URL if ($ENV{'PATH_INFO'}) { - print "<base href=\"".esc_url($base_url)."\" />\n"; + print "<base href=\"".esc_url($base_url)."/\" />\n"; } print_header_links($status);
-- 2.39.0