git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/5] tag: factor out sig detection for tag display

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Nov 6, 2010, 11:04 UTC
Message-ID
<581c3740a07c6a9470d7dba13d23721881095d42.1289041051.git.git@drmicha.warpmail.net>
In-Reply-To
<4CAB90EC.1080302@drmicha.warpmail.net>
Use the factored out code for sig detection when displaying tags.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
 builtin/tag.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/tag.c b/builtin/tag.c
index 66feeb0..617a58f 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -68,9 +68,9 @@ static int show_reference(const char *refname, const unsigned char *sha1,
 			return 0;
 		}
 		/* only take up to "lines" lines, and strip the signature */
+		size = parse_signature(buf, size);
 		for (i = 0, sp += 2;
-				i < filter->lines && sp < buf + size &&
-				prefixcmp(sp, PGP_SIGNATURE "\n");
+				i < filter->lines && sp < buf + size;
 				i++) {
 			if (i)
 				printf("\n    ");
-- 
1.7.3.2.193.g78bbb
Previous: Michael J GruberNext: Michael J Gruber
Message 32 of 39 in “Error when verifying tags signed using 1.7.3.1”
  1. Stephan HugelOct 4, 2010
  2. Daniel JohnsonOct 4, 2010
  3. Stephan HugelOct 4, 2010
  4. Daniel JohnsonOct 4, 2010
  5. Stephan HugelOct 5, 2010
  6. Michael J GruberOct 5, 2010
  7. Stephan HugelOct 5, 2010
  8. Michael J GruberOct 5, 2010
  9. Stephan HugelOct 5, 2010
  10. Michael J GruberOct 5, 2010
  11. tag,verify-tag: do not trip over rfc1991 signaturesMichael J Gruber, Oct 5, 2010
  12. Junio C HamanoOct 5, 2010
  13. Michael J GruberOct 5, 2010
  14. Stephan HugelOct 5, 2010
  15. Michael J GruberOct 5, 2010
  16. 0/5 Handling of rfc1991 signaturesMichael J Gruber, Nov 6, 2010
  17. 0/5 Handling of rfc1991 signaturesMichael J Gruber, Nov 10, 2010
  18. Junio C HamanoNov 10, 2010
  19. 1/5 t/t7004-tag: test handling of rfc1991 signaturesMichael J Gruber, Nov 10, 2010
  20. 2/5 verify-tag: factor out signature detectionMichael J Gruber, Nov 10, 2010
  21. 3/5 tag: factor out sig detection for body editsMichael J Gruber, Nov 10, 2010
  22. 4/5 tag: factor out sig detection for tag displayMichael J Gruber, Nov 10, 2010
  23. 5/5 tag: recognize rfc1991 signaturesMichael J Gruber, Nov 10, 2010
  24. 1/5 t/t7004-tag: test handling of rfc1991 signaturesMichael J Gruber, Nov 6, 2010
  25. Junio C HamanoNov 9, 2010
  26. Michael J GruberNov 9, 2010
  27. Junio C HamanoNov 10, 2010
  28. Michael J GruberNov 10, 2010
  29. 2/5 verify-tag: factor out signature detectionMichael J Gruber, Nov 6, 2010
  30. Thiago FarinaNov 6, 2010
  31. 3/5 tag: factor out sig detection for body editsMichael J Gruber, Nov 6, 2010
  32. 4/5 tag: factor out sig detection for tag displayMichael J Gruber, Nov 6, 2010
  33. 5/5 tag: recognize rfc1991 signaturesMichael J Gruber, Nov 6, 2010
  34. Thiago FarinaNov 6, 2010
  35. Junio C HamanoNov 8, 2010
  36. Todd ZullingerOct 5, 2010
  37. Michael J GruberOct 5, 2010
  38. Stephan HugelOct 5, 2010
  39. Pat ThoytsOct 5, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.