git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] run-command: async_exit no longer needs to be public

From
Lars Schneider <larsxschneider@gmail.com>
Date
Sep 23, 2016, 08:26 UTC
Message-ID
<58164A5E-AC93-48A9-9139-B69CFB854CA8@gmail.com>
In-Reply-To
<78f2bdd0-f6ad-db5c-f9f2-f90528bc4f77@ramsayjones.plus.com>
Show 16 quoted lines
> On 22 Sep 2016, at 18:56, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
> 
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Lars,
> 
> If you need to re-roll your 'ls/filter-process' branch, could you please
> squash this into the relevant commit c42a4cbc ("run-command: move check_pipe()
> from write_or_die to run_command", 20-09-2016).
> 
> [Note that commit 9658846c ("write_or_die: handle EPIPE in async threads",
> 24-02-2016) introduced async_exit() specifically for use in the implementation
> of check_pipe(). Now that you have moved check_pipe() into run-command.c,
> it no longer needs to be public.]
Hi Ramsay,

thanks for noticing this. I actually hope that I don't need another re-roll :-) If I don't re-roll. Should I make a patch with this cleanup or do you take care of it?

Thanks, Lars

Previous: Ramsay JonesNext: Junio C Hamano
Message 2 of 6 in “run-command: async_exit no longer needs to be public”
  1. run-command: async_exit no longer needs to be publicRamsay Jones, Sep 22, 2016
  2. Lars SchneiderSep 23, 2016
  3. Junio C HamanoSep 23, 2016
  4. Lars SchneiderSep 23, 2016
  5. Junio C HamanoSep 23, 2016
  6. Ramsay JonesSep 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.