[PATCH v2 4/4] Convert remaining die*(BUG) messages
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 2, 2018, 09:38 UTC
- Message-ID
- <57b3a3e9fe3a04e1f9fbcad9164bc71929d4bb29.1525253893.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <cover.1525253892.git.johannes.schindelin@gmx.de>
These were not caught by the previous commit, as they did not match the regular expression.
While at it, remove the localization from one instance: we never want BUG() messages to be translated, as they target Git developers, not the end user (hence it would be quite unhelpful to not only burden the translators, but then even end up with a bug report in a language that no core Git contributor understands).
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- git-compat-util.h | 2 +- pathspec.c | 2 +- submodule.c | 2 +- vcs-svn/fast_export.c | 6 ++++-- 4 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h index 07e383257b4..3a7216f5313 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -1052,7 +1052,7 @@ int git_qsort_s(void *base, size_t nmemb, size_t size, #define QSORT_S(base, n, compar, ctx) do { \ if (qsort_s((base), (n), sizeof(*(base)), compar, ctx)) \ - die("BUG: qsort_s() failed"); \ + BUG("qsort_s() failed"); \ } while (0) #ifndef REG_STARTEND diff --git a/pathspec.c b/pathspec.c index a637a6d15c0..27cd6067860 100644 --- a/pathspec.c +++ b/pathspec.c @@ -486,7 +486,7 @@ static void init_pathspec_item(struct pathspec_item *item, unsigned flags, /* sanity checks, pathspec matchers assume these are sane */ if (item->nowildcard_len > item->len || item->prefix > item->len) { - die ("BUG: error initializing pathspec_item"); + BUG("error initializing pathspec_item"); } } diff --git a/submodule.c b/submodule.c index 733db441714..c282fa8fe51 100644 --- a/submodule.c +++ b/submodule.c @@ -2043,7 +2043,7 @@ const char *get_superproject_working_tree(void) if (super_sub_len > cwd_len || strcmp(&cwd[cwd_len - super_sub_len], super_sub)) - die (_("BUG: returned path string doesn't match cwd?")); + BUG("returned path string doesn't match cwd?"); super_wt = xstrdup(cwd); super_wt[cwd_len - super_sub_len] = '\0'; diff --git a/vcs-svn/fast_export.c b/vcs-svn/fast_export.c index 3fd047a8b82..b5b8913cb0f 100644 --- a/vcs-svn/fast_export.c +++ b/vcs-svn/fast_export.c @@ -320,7 +320,8 @@ const char *fast_export_read_path(const char *path, uint32_t *mode_out) err = fast_export_ls(path, mode_out, &buf); if (err) { if (errno != ENOENT) - die_errno("BUG: unexpected fast_export_ls error"); + BUG("unexpected fast_export_ls error: %s", + strerror(errno)); /* Treat missing paths as directories. */ *mode_out = S_IFDIR; return NULL; @@ -338,7 +339,8 @@ void fast_export_copy(uint32_t revision, const char *src, const char *dst) err = fast_export_ls_rev(revision, src, &mode, &data); if (err) { if (errno != ENOENT) - die_errno("BUG: unexpected fast_export_ls_rev error"); + BUG("unexpected fast_export_ls_rev error: %s", + strerror(errno)); fast_export_delete(dst); return; }
-- 2.17.0.windows.1.36.gdf4ca5fb72a