git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/4] commit: use xstrdup() in get_merge_parent()

From
René Scharfe <l.s.r@web.de>
Date
Aug 13, 2016, 12:09 UTC
Message-ID
<57AF0E0D.9030205@web.de>
In-Reply-To
<57AF0D8E.6040309@web.de>

Handle allocation errors for the name member just like we already do for the struct merge_remote_desc itself.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commit.c b/commit.c
index 71a360d..ccd232a 100644
--- a/commit.c
+++ b/commit.c
@@ -1589,7 +1589,7 @@ struct commit *get_merge_parent(const char *name)
 		struct merge_remote_desc *desc;
 		desc = xmalloc(sizeof(*desc));
 		desc->obj = obj;
-		desc->name = strdup(name);
+		desc->name = xstrdup(name);
 		commit->util = desc;
 	}
 	return commit;
-- 
2.9.3
Previous: René ScharfeNext: René Scharfe
Message 4 of 8 in “commit: introduce set_merge_remote_desc()”
  1. commit: introduce set_merge_remote_desc()René Scharfe, Aug 13, 2016
  2. Jeff KingAug 13, 2016
  3. René ScharfeAug 13, 2016
  4. 1/4 commit: use xstrdup() in get_merge_parent()René Scharfe, Aug 13, 2016
  5. 2/4 commit: factor out set_merge_remote_desc()René Scharfe, Aug 13, 2016
  6. 3/4 merge-recursive: fix verbose output for multiple base treesRené Scharfe, Aug 13, 2016
  7. 4/4 commit: use FLEX_ARRAY in struct merge_remote_descRené Scharfe, Aug 13, 2016
  8. Jeff KingAug 13, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.