Re: [PATCH v3 7/8] status: update git-status.txt for --porcelain=v2

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Aug 2, 2016, 16:29 UTC
Message-ID: <57A0CA79.7040809@jeffhostetler.com>
In-Reply-To: <4afec4ce-ecb4-dcce-b8f5-c37844d963d8@gmail.com>

On 08/02/2016 11:19 AM, Jakub Narębski wrote:

Show 43 quoted lines

> W dniu 01.08.2016 o 17:39, Jeff Hostetler pisze:
>> On 07/30/2016 01:22 PM, Jakub Narębski wrote:
>>> W dniu 26.07.2016 o 23:11, Jeff Hostetler pisze:
>>>
>>> This is a nice change, available because of lack of backward
>>> compatibility with v1.  The porcelain v2 format branch-related
>>> information could be enhanced without risk of breaking parsers,
>>> or having new information put at the end even if it does not fit
>>> there (like in previous iteration).
>>>
>>> One thing that can serve as goal for the series is using the
>>> question: would it make __git_ps1() from git-prompt.sh be able
>>> to render fully decorated prompt with all bells and whistles,
>>> and with all combinations of options.  Thus beside upstream
>>> in the future we might want SVN upstream, and/or pushed-to
>>> remote branch (and remote push upstream repository), etc.
>>>
>>> But that's for the future (and it is possible for the future)...
>>>
>>
>> Yes, I was hoping to be able to simplify and/or speed up
>> __git_ps1() with this data.  "Namespacing" the branch data
>> here.  And then later add the state data (in a merge,
>> in a rebase, and etc.) in a series of "# state.*" headers.
>> And so on, until we get everything that __git_ps1() needs.
>> However, to really make that work, we might want to add
>> a --no-scan (or minimial scan) option, to just return the
>> header data, since __git_ps1() doesn't care about the list
>> of changes.
>
> But __git_ps1() with GIT_PS1_SHOWDIRTYSTATE would want to know
> if there are unstaged and staged changes, and with
> GIT_PS1_SHOWUNTRACKEDFILES it would want to know if there
> are untracked (unknown) files, isn't it?
>
> And GIT_PS1_SHOWSTASHSTATE would want to know if there is
> something stashed, but I guess it is outside the remit of
> git-status...
>
> Also, __git_ps1() uses colors from git-status, so if it
> is switched to use --porcelain=v2, then there should be an
> option to turn the color on, isn't it?
>

All of these are good questions. But __git_ps1() is outside my scope right now. All I was saying above is that by making the branch details available here and, later, extending V2 output by adding other such headers to the output, we could try to remove much of the business logic in __git_ps1() and hopefully reduce it to just formatting and coloring the prompt using the computed result from status.

But I've only skimmed __git_ps1() (and it's a little dense), so I'd have to study it more before I could answer all of your questions.

Thanks, Jeff