git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] refs/files-backend: mark a file-local symbol static

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Jun 24, 2016, 20:31 UTC
Message-ID
<576D9885.2020901@ramsayjones.plus.com>

Commit 6d41edc6 ("refs: add methods for reflog", 24-02-2016), moved the reflog handling into the ref-storage backend. In particular, the files_reflog_iterator_begin() API was removed from internal refs API header, resulting in sparse warnings.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Michael,

If you need to re-roll your 'mh/ref-store' branch, could you please squash this into the relevant patch. (or something like it - if you think this function should be public, then re-introduce the declaration to the header).

Thanks!

ATB, Ramsay Jones

 refs/files-backend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/refs/files-backend.c b/refs/files-backend.c
index b6ce19f..426e439 100644
--- a/refs/files-backend.c
+++ b/refs/files-backend.c
@@ -3331,7 +3331,7 @@ static struct ref_iterator_vtable files_reflog_iterator_vtable = {
 	files_reflog_iterator_abort
 };
 
-struct ref_iterator *files_reflog_iterator_begin(struct ref_store *ref_store)
+static struct ref_iterator *files_reflog_iterator_begin(struct ref_store *ref_store)
 {
 	struct files_reflog_iterator *iter = xcalloc(1, sizeof(*iter));
 	struct ref_iterator *ref_iterator = &iter->base;
-- 
2.9.0
Message 1 of 1 in “refs/files-backend: mark a file-local symbol static”
  1. refs/files-backend: mark a file-local symbol staticRamsay Jones, Jun 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.