git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 43/44] builtin/apply: add a cli option for be_silent

From
René Scharfe <l.s.r@web.de>
Date
Jun 10, 2016, 20:59 UTC
Message-ID
<575B2A2E.3000403@web.de>
In-Reply-To
<20160610201118.13813-44-chriscool@tuxfamily.org>
Am 10.06.2016 um 22:11 schrieb Christian Couder:
Show 21 quoted lines
> Let's make it possible to request a silent operation on the
> command line.
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>   builtin/apply.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/builtin/apply.c b/builtin/apply.c
> index ddd61de..93744f8 100644
> --- a/builtin/apply.c
> +++ b/builtin/apply.c
> @@ -74,6 +74,8 @@ int cmd_apply(int argc, const char **argv, const char *prefix)
>   		OPT_BOOL(0, "allow-overlap", &state.allow_overlap,
>   			N_("allow overlapping hunks")),
>   		OPT__VERBOSE(&state.apply_verbosely, N_("be verbose")),
> +		OPT_BOOL(0, "silent", &state.be_silent,
> +			N_("do not print any output")),
>   		OPT_BIT(0, "inaccurate-eof", &options,
>   			N_("tolerate incorrectly detected missing new-line at the end of file"),
>   			APPLY_OPT_INACCURATE_EOF),
Why not -q/--quiet as for most other commands?

Furthermore, you could use OPT__VERBOSITY, which causes -v and -q to update the same variable variable and thus lets parseopt handle their interaction. Perhaps verbosity == 1 could mean verbose, 0 normal, -1 no infos, -2 no warnings and -3 no errors?

And if you add the ability to silence the apply functions before using them you don't have to export and unexport dup_devnull().

René
Previous: Christian CouderNext: Christian Couder
Message 27 of 50 in “libify apply and use lib in am, part 2”
  1. 00/44 libify apply and use lib in am, part 2Christian Couder, Jun 10, 2016
  2. 02/44 builtin/apply: make apply_patch() return -1 instead of die()ingChristian Couder, Jun 10, 2016
  3. 07/44 builtin/apply: make parse_whitespace_option() return -1 instead of die()ingChristian Couder, Jun 10, 2016
  4. 01/44 apply: move 'struct apply_state' to apply.hChristian Couder, Jun 10, 2016
  5. 06/44 builtin/apply: make parse_single_patch() return -1 on errorChristian Couder, Jun 10, 2016
  6. 10/44 apply: make init_apply_state() return -1 instead of exit()ingChristian Couder, Jun 10, 2016
  7. 04/44 builtin/apply: make find_header() return -1 instead of die()ingChristian Couder, Jun 10, 2016
  8. 16/44 builtin/apply: make gitdiff_*() return -1 on errorChristian Couder, Jun 10, 2016
  9. 15/44 builtin/apply: make gitdiff_*() return 1 at end of headerChristian Couder, Jun 10, 2016
  10. 23/44 builtin/apply: make write_out_one_result() return -1 on errorChristian Couder, Jun 10, 2016
  11. 17/44 builtin/apply: change die_on_unsafe_path() to check_unsafe_path()Christian Couder, Jun 10, 2016
  12. 25/44 builtin/apply: make try_create_file() return -1 on errorChristian Couder, Jun 10, 2016
  13. 18/44 builtin/apply: make build_fake_ancestor() return -1 on errorChristian Couder, Jun 10, 2016
  14. 27/44 builtin/apply: rename option parsing functionsChristian Couder, Jun 10, 2016
  15. 28/44 apply: rename and move opt constants to apply.hChristian Couder, Jun 10, 2016
  16. 22/44 builtin/apply: make create_file() return -1 on errorChristian Couder, Jun 10, 2016
  17. 21/44 builtin/apply: make add_index_file() return -1 on errorChristian Couder, Jun 10, 2016
  18. 26/44 builtin/apply: make create_one_file() return -1 on errorChristian Couder, Jun 10, 2016
  19. 24/44 builtin/apply: make write_out_results() return -1 on errorChristian Couder, Jun 10, 2016
  20. 31/44 run-command: make dup_devnull() non staticChristian Couder, Jun 10, 2016
  21. Johannes SixtJun 11, 2016
  22. Christian CouderJun 11, 2016
  23. 35/44 apply: add 'be_silent' variable to 'struct apply_state'Christian Couder, Jun 10, 2016
  24. 36/44 apply: make 'be_silent' incompatible with 'apply_verbosely'Christian Couder, Jun 10, 2016
  25. 37/44 apply: don't print on stdout when be_silent is setChristian Couder, Jun 10, 2016
  26. 43/44 builtin/apply: add a cli option for be_silentChristian Couder, Jun 10, 2016
  27. René ScharfeJun 10, 2016
  28. Christian CouderJun 11, 2016
  29. 38/44 usage: add set_warn_routine()Christian Couder, Jun 10, 2016
  30. 44/44 apply: use error_errno() where possibleChristian Couder, Jun 10, 2016
  31. 39/44 usage: add get_error_routine() and get_warn_routine()Christian Couder, Jun 10, 2016
  32. 41/44 am: use be_silent in 'struct apply_state' to shut up applying patchesChristian Couder, Jun 10, 2016
  33. Junio C HamanoJun 10, 2016
  34. Christian CouderJun 11, 2016
  35. 42/44 run-command: make dup_devnull() static againChristian Couder, Jun 10, 2016
  36. 40/44 apply: change error_routine when be_silent is setChristian Couder, Jun 10, 2016
  37. 30/44 apply: make some parsing functions static againChristian Couder, Jun 10, 2016
  38. 34/44 write_or_die: use warning() instead of fprintf(stderr, ...)Christian Couder, Jun 10, 2016
  39. 33/44 builtin/am: use apply api in run_apply()Christian Couder, Jun 10, 2016
  40. 19/44 builtin/apply: make remove_file() return -1 on errorChristian Couder, Jun 10, 2016
  41. 32/44 environment: add set_index_file()Christian Couder, Jun 10, 2016
  42. 20/44 builtin/apply: make add_conflicted_stages_file() return -1 on errorChristian Couder, Jun 10, 2016
  43. 14/44 builtin/apply: make parse_traditional_patch() return -1 on errorChristian Couder, Jun 10, 2016
  44. 12/44 builtin/apply: move check_apply_state() to apply.cChristian Couder, Jun 10, 2016
  45. 09/44 builtin/apply: move init_apply_state() to apply.cChristian Couder, Jun 10, 2016
  46. 11/44 builtin/apply: make check_apply_state() return -1 instead of die()ingChristian Couder, Jun 10, 2016
  47. 13/44 builtin/apply: make apply_all_patches() return -1 on errorChristian Couder, Jun 10, 2016
  48. 03/44 builtin/apply: read_patch_file() return -1 instead of die()ingChristian Couder, Jun 10, 2016
  49. 08/44 builtin/apply: make parse_ignorewhitespace_option() return -1 instead of die()ingChristian Couder, Jun 10, 2016
  50. 05/44 builtin/apply: make parse_chunk() return a negative integer on errorChristian Couder, Jun 10, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.