Re: [PATCH] Fix wrong info in `INSTALL`
- From
Philippe Blain <levraiphilippeblain@gmail.com>
- Date
- May 24, 2022, 22:03 UTC
- Message-ID
- <572f5565-3892-2056-f202-b547ced4a9fc@gmail.com>
- In-Reply-To
- <220524.86a6b6vcao.gmgdl@evledraar.gmail.com>
Hi Shao-Ce,
Le 2022-05-24 à 17:39, Ævar Arnfjörð Bjarmason a écrit :
Show 32 quoted lines
> > On Tue, May 24 2022, Shao-Ce SUN via GitGitGadget wrote: > >> From: Shao-Ce SUN <sunshaoce@iscas.ac.cn> >> >> The user prompt should be `$` instead of `#`. >> >> Signed-off-by: Shao-Ce SUN <sunshaoce@iscas.ac.cn> >> --- >> Fix wrong info in INSTALL >> >> The user prompt should be $ instead of #. >> >> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1241%2Fsunshaoce%2Finstall-v1 >> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1241/sunshaoce/install-v1 >> Pull-Request: https://github.com/gitgitgadget/git/pull/1241 >> >> INSTALL | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/INSTALL b/INSTALL >> index 4140a3f5c8b..7bb3f48311d 100644 >> --- a/INSTALL >> +++ b/INSTALL >> @@ -5,8 +5,8 @@ Normally you can just do "make" followed by "make install", and that >> will install the git programs in your own ~/bin/ directory. If you want >> to do a global install, you can do >> >> - $ make prefix=/usr all doc info ;# as yourself >> - # make prefix=/usr install install-doc install-html install-info ;# as root >> + $ make prefix=/usr all doc info ; $ as yourself >> + # make prefix=/usr install install-doc install-html install-info ; # as root
The prompt for the first invocation is already '$', what you are changing in the first line is the '# as yourself' comment which is a shell comment and thus uses '#'. This allows the whole line to be pasted as-is.
The second line is supposed to be ran as root and already has '#' as prompt, and also has '# as root' as a comment, which you simply prefix with a space.
I don't think there is anything to "fix" here...
Show 15 quoted lines
>> >> (or prefix=/usr/local, of course). Just like any program suite >> that uses $prefix, the built results have some paths encoded, >> @@ -20,10 +20,10 @@ config.mak file. >> Alternatively you can use autoconf generated ./configure script to >> set up install paths (via config.mak.autogen), so you can write instead >> >> - $ make configure ;# as yourself >> - $ ./configure --prefix=/usr ;# as yourself >> - $ make all doc ;# as yourself >> - # make install install-doc install-html;# as root >> + $ make configure ; $ as yourself >> + $ ./configure --prefix=/usr ; $ as yourself >> + $ make all doc ; $ as yourself >> + # make install install-doc install-html; # as root
Same here.