Re: [PATCH] always start looking up objects in the last used pack first

From: Dana How <danahow@gmail.com>
Date: Jun 2, 2007, 15:00 UTC
Message-ID: <56b7f5510706020800o10541844t151cb82221d077d5@mail.gmail.com>
In-Reply-To: <alpine.LFD.0.99.0705311015410.11491@xanadu.home>

On 5/31/07, Nicolas Pitre <nico@cam.org> wrote:

Show 8 quoted lines

> Which makes me wonder about a possible incremental improvement to my
> patch: on failure to find an object in the last used pack, the search
> should then start again from the pack containing the commit from which
> this object search is related to.  In the split pack case all commit
> objects will be located in the first pack so nothing will change there.
> In the multiple-fetch case then the search will always reset to packs
> not younger than the commit triggering those object lookups.  Question
> is how to implement that nicely...

My immediate reaction to this patch was that there should be a last-used-pack per object type. Or perhaps one for commits, and one for trees+blobs [since the latter are intermingled]? Unfortunately the interface only specifies the SHA-1, not the object type, and certainly not the "commit this is related to". I think your related-commit idea could be very useful, but it does require some extra info to be passed around which currently is not.

-- 
Dana L. How  danahow@gmail.com  +1 650 804 5991 cell