Re: [PATCH 1/8] git-repack --max-pack-size: Add new file statics and struct fields

From: Dana How <danahow@gmail.com>
Date: Apr 9, 2007, 18:38 UTC
Message-ID: <56b7f5510704091138r166d6caer7ea4b2497889a4c0@mail.gmail.com>
In-Reply-To: <7vabxi8lqv.fsf@assigned-by-dhcp.cox.net>

On 4/8/07, Junio C Hamano <junkio@cox.net> wrote:

Show 12 quoted lines

> Dana How <danahow@gmail.com> writes:
>
> > ... The fields
> > in object_entry are re-arranged & shrunk to save memory.
>
> Is the driving principle "place fields with coarser alignment
> requirements first in the struct"?  I noticed you have a handful
> pointers and an off_t after two short fields.  Two shorts would
> be likely to make the next field aligned suitable for an int,
> but (1) if we ever add another short later that would not be
> true anymore, and (2) I suspect a pointer and an off_t can be
> longer than an int but int would never be longer than them.

All true. My objective was to save more memory than I had "wasted" by adding the prev_pack field. Since it appears I'll be submitting the patchset yet again, I'll make this re-arrangement complete next time.

Thanks,

-- 
Dana L. How  danahow@gmail.com  +1 650 804 5991 cell