Re: [PATCH] gitlab-ci: always run MSVC-based Meson job

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 28, 2025, 10:59 UTC
Message-ID: <56a0f8fd-7568-b579-1ff3-e0b088b53345@gmx.de>
In-Reply-To: <20250428-pks-gitlab-ci-execute-win-meson-v1-1-f68683552b9e@pks.im>

Hi Patrick,

On Mon, 28 Apr 2025, Patrick Steinhardt wrote:

Show 9 quoted lines

> With 7304bd2bc39 (ci: wire up Visual Studio build with Meson,
> 2025-01-22) we have introduced a CI job that builds and tests Git with
> Microsoft Visual Studio via Meson. This job is only being executed by
> default on GitHub Workflows though -- on GitLab CI it is marked as a
> "manual" job, so the developer has to actively trigger these jobs.
> 
> The consequence of this split is that any breakage specific to this job
> is only noticed by developers who mainly work with GitHub. Let's improve
> this situation by also running the job by default on GitLab CI.

The rationale makes sense to me, even if the added runtime (and consumption of resources) is quite contrary to what I would like. From my point of view, Git is spending way more compute than is warranted. The way Git's CI builds are set up, in many cases a single regression will cause many tests/jobs to fail, and that indicates to me that Git's CI definition (and even Git's test suite) contains too many redundant parts.

Having said that, with the rationale provided in the commit message, this patch looks good to me.

Ciao, Johannes

Show 32 quoted lines

> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> As proposed in [1]. A test run of this pipeline can be found at [2].
> Thanks!
> 
> Patrick
> 
> [1]: <aA8ymUzWM2t0QkFP@pks.im>
> [2]: https://gitlab.com/gitlab-org/git/-/merge_requests/349
> ---
>  .gitlab-ci.yml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 4798b283745..bb6d5b976cd 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -173,7 +173,6 @@ build:msvc-meson:
>  test:msvc-meson:
>    extends: .msvc-meson
>    stage: test
> -  when: manual
>    timeout: 6h
>    needs:
>      - job: "build:msvc-meson"
> 
> ---
> base-commit: f65182a99e545d2f2bc22e6c1c2da192133b16a3
> change-id: 20250428-pks-gitlab-ci-execute-win-meson-e54998fa7081
> 
>