git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git-compat-util: st_add4: work around gcc 4.2.x compiler crash

From
Torsten Bögershausen <tboegi@web.de>
Date
Mar 21, 2016, 17:46 UTC
Message-ID
<56F0336E.6000103@web.de>
In-Reply-To
<1458534958-6956-2-git-send-email-sunshine@sunshineco.com>
On 2016-03-21 05.35, Eric Sunshine wrote:
Show 6 quoted lines
>  }
> -#define st_add3(a,b,c)   st_add((a),st_add((b),(c)))
> -#define st_add4(a,b,c,d) st_add((a),st_add3((b),(c),(d)))
> +#define st_add3(a,b,c)   st_add(st_add((a),(b)),(c))
> +#define st_add4(a,b,c,d) st_add(st_add3((a),(b),(c)),(d))
>  

That fix compiles on my test machine, and passes the test suite. thanks for digging.

Previous: Eric SunshineNext: Eric Sunshine
Message 6 of 7 in “work around gcc 4.2.x compiler crash”
  1. 0/2 work around gcc 4.2.x compiler crashEric Sunshine, Mar 21, 2016
  2. 1/2 git-compat-util: st_add4: work around gcc 4.2.x compiler crashEric Sunshine, Mar 21, 2016
  3. Jeff KingMar 21, 2016
  4. Christian CouderMar 21, 2016
  5. Eric SunshineMar 21, 2016
  6. Torsten BögershausenMar 21, 2016
  7. 2/2 Revert "config.mak.uname: use clang for Mac OS X 10.6"Eric Sunshine, Mar 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.