[PATCH 2/2] xdiff/xprepare: fix a memory leak
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Mar 4, 2016, 23:10 UTC
- Message-ID
- <56DA15FA.1090601@ramsayjones.plus.com>
The xdl_prepare_env() function may initialise an xdlclassifier_t data structure via xdl_init_classifier(), which allocates memory to several fields, for example 'rchash', 'rcrecs' and 'ncha'. If this function later exits due to the failure of xdl_optimize_ctxs(), then this xdlclassifier_t structure, and the memory allocated to it, is not cleaned up.
In order to fix the memory leak, insert a call to xdl_free_classifier() before returning.
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com> --- xdiff/xprepare.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/xdiff/xprepare.c b/xdiff/xprepare.c index 5ffcf99..13b55ab 100644 --- a/xdiff/xprepare.c +++ b/xdiff/xprepare.c @@ -301,6 +301,7 @@ int xdl_prepare_env(mmfile_t *mf1, mmfile_t *mf2, xpparam_t const *xpp, xdl_free_ctx(&xe->xdf2); xdl_free_ctx(&xe->xdf1); + xdl_free_classifier(&cf); return -1; }
-- 2.7.0