git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] xdiff/xprepare: use the XDF_DIFF_ALG() macro to access flag bits

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Mar 4, 2016, 23:09 UTC
Message-ID
<56DA15B0.6050306@ramsayjones.plus.com>

Commit 307ab20b3 ("xdiff: PATIENCE/HISTOGRAM are not independent option bits", 19-02-2012) introduced the XDF_DIFF_ALG() macro to access the flag bits used to represent the diff algorithm requested. In addition, code which had used explicit manipulation of the flag bits was changed to use the macros.

However, one example of direct manipulation remains. Update this code to use the XDF_DIFF_ALG() macro.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
 xdiff/xprepare.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xdiff/xprepare.c b/xdiff/xprepare.c
index 63a22c6..5ffcf99 100644
--- a/xdiff/xprepare.c
+++ b/xdiff/xprepare.c
@@ -304,7 +304,7 @@ int xdl_prepare_env(mmfile_t *mf1, mmfile_t *mf2, xpparam_t const *xpp,
 		return -1;
 	}
 
-	if (!(xpp->flags & XDF_HISTOGRAM_DIFF))
+	if (XDF_DIFF_ALG(xpp->flags) != XDF_HISTOGRAM_DIFF)
 		xdl_free_classifier(&cf);
 
 	return 0;
-- 
2.7.0
Message 1 of 1 in “xdiff/xprepare: use the XDF_DIFF_ALG() macro to access flag bits”
  1. 1/2 xdiff/xprepare: use the XDF_DIFF_ALG() macro to access flag bitsRamsay Jones, Mar 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.