Re: GSoC 2016 Microproject

From: Sidhant Sharma <tigerkid001@gmail.com>
Date: Feb 29, 2016, 15:32 UTC
Message-ID: <56D46493.4040909@gmail.com>
In-Reply-To: <vpqpovfblru.fsf@anie.imag.fr>

Show 10 quoted lines

>> First, I'm not quite sure what to put in the help message for the
>> options (--quiet, --stateless-rpc, --advertise-refs and
>> --reject-thin-pack-for-testing).
> They are currently undocumented. We sometimes have explicitly
> undocumented options (PARSE_OPT_HIDDEN) when they are used only
> internally to avoid polluting the end-user's UI.
>
> In this case, the command is anyway not meant for end-users so I think
> it would make sense to document them, but not necessarily within the the
> microproject.

So what may I put in the message parameter? I was thinking perhaps the option itself, without hyphens. Would that be correct?

Show 9 quoted lines

>
>> Second, regarding the reject-thin-pack-for-testing option, currently
>> when the option is entered, `fix_thin` is unset
>> (https://github.com/git/git/blob/master/builtin/receive-pack.c#L1736).
>> But using `OPT_BOOL(...)` for the same, the variable would instead be
>> set when the option is given. I think one solution can be to invert
>> `fix_thin` after calling `parse_options`. Am I going right so far?
>> Suggestions and corrections welcome.
> Or use OPT_SET_INT(..., 0) on a variable initialized to 1.

Okay, will do that.

>> Should I make a patch for this and submit it for discussion on the mailing list?
> On this list, it is indeed often more efficient to say "here's what I'm
> done. Any comments?" than "here's what I'm about to do".
>

I'm really sorry, I'm not very familiar with mailing list etiquettes. I'll keep that in mind :)

Thanks and regards, Sidhant Sharma [:tk]