git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] run-command: fix an 'different modifiers' sparse warning

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Feb 25, 2016, 19:35 UTC
Message-ID
<56CF576B.4020401@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Jeff,

If you need to re-roll your 'jk/epipe-in-async' branch, could you please squash this into the relevant patch. (ie. "write_or_die: handle EPIPE in async threads", 24-02-2016).

Thanks!

ATB, Ramsay Jones

 run-command.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/run-command.c b/run-command.c
index cd861bc..5dec18b 100644
--- a/run-command.c
+++ b/run-command.c
@@ -625,7 +625,7 @@ int in_async(void)
 	return !pthread_equal(main_thread, pthread_self());
 }
 
-void async_exit(int code)
+void NORETURN async_exit(int code)
 {
 	pthread_exit((void *)(intptr_t)code);
 }
@@ -675,7 +675,7 @@ int in_async(void)
 	return process_is_async;
 }
 
-int async_exit(int code)
+int NORETURN async_exit(int code)
 {
 	exit(code);
 }
-- 
2.7.0
Next: Junio C Hamano
Message 1 of 4 in “run-command: fix an 'different modifiers' sparse warning”
  1. run-command: fix an 'different modifiers' sparse warningRamsay Jones, Feb 25, 2016
  2. Junio C HamanoFeb 25, 2016
  3. Jeff KingFeb 25, 2016
  4. Ramsay JonesFeb 25, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.