git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] refs: reduce the visibility of do_for_each_ref()

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Feb 23, 2016, 00:39 UTC
Message-ID
<56CBAA31.7030809@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi David,
Again, If you need to re-roll your 'dt/refs-backend-lmdb' branch ...
Thanks!

ATB, Ramsay Jones

 refs.c               | 16 ++++++++--------
 refs/refs-internal.h |  6 ------
 2 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/refs.c b/refs.c
index 337f110..bf70876 100644
--- a/refs.c
+++ b/refs.c
@@ -1236,6 +1236,14 @@ static int get_affected_refnames(struct ref_transaction *transaction,
 	return 0;
 }
 
+static int do_for_each_ref(const char *submodule, const char *base,
+			   each_ref_fn fn, int trim, int flags,
+			   void *cb_data)
+{
+	return the_refs_backend->do_for_each_ref(submodule, base, fn, trim,
+						 flags, cb_data);
+}
+
 int for_each_ref(each_ref_fn fn, void *cb_data)
 {
 	return do_for_each_ref(NULL, "", fn, 0, 0, cb_data);
@@ -1501,14 +1509,6 @@ int resolve_gitlink_ref(const char *path, const char *refname,
 	return the_refs_backend->resolve_gitlink_ref(path, refname, sha1);
 }
 
-int do_for_each_ref(const char *submodule, const char *base,
-		    each_ref_fn fn, int trim, int flags,
-		    void *cb_data)
-{
-	return the_refs_backend->do_for_each_ref(submodule, base, fn, trim,
-						 flags, cb_data);
-}
-
 int for_each_reflog_ent_reverse(const char *refname, each_reflog_ent_fn fn,
 				void *cb_data)
 {
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index ced6af4..4922e25 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
@@ -227,12 +227,6 @@ int do_for_each_per_worktree_ref(const char *submodule, const char *base,
 				 each_ref_fn fn, int trim, int flags,
 				 void *cb_data);
 
-/*
- * The common backend for the for_each_*ref* functions
- */
-int do_for_each_ref(const char *submodule, const char *base,
-		    each_ref_fn fn, int trim, int flags, void *cb_data);
-
 /* refs backends */
 typedef int ref_init_db_fn(int shared, struct strbuf *err);
 typedef int ref_transaction_commit_fn(struct ref_transaction *transaction,
-- 
2.7.0
Next: David Turner
Message 1 of 2 in “refs: reduce the visibility of do_for_each_ref()”
  1. refs: reduce the visibility of do_for_each_ref()Ramsay Jones, Feb 23, 2016
  2. David TurnerFeb 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.