git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] attempt connects in parallel for IPv6-capable builds

From
Johannes Sixt <j6t@kdbg.org>
Date
Jan 29, 2016, 07:10 UTC
Message-ID
<56AB1057.6080700@kdbg.org>
In-Reply-To
<20160129014106.GA8940@dcvr.yhbt.net>
Am 29.01.2016 um 02:41 schrieb Eric Wong:
Show 41 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote:
>> Eric Wong <normalperson@yhbt.net> writes:
>>
>>> getaddrinfo() may return multiple addresses, not all of which
>>> are equally performant.  In some cases, a user behind a non-IPv6
>>> capable network may get an IPv6 address which stalls connect().
>>> Instead of waiting synchronously for a connect() to timeout, use
>>> non-blocking connect() in parallel and take the first successful
>>> connection.
>>>
>>> This may increase network traffic and server load slightly, but
>>> makes the worst-case user experience more bearable when one
>>> lacks permissions to edit /etc/gai.conf to favor IPv4 addresses.
>>
>> Umm.  I am not sure what to think about this change--I generally do
>> not like a selfish "I'll try to use whatever resource given to me
>> to make my process go faster, screw the rest of the world" approach
>> and I cannot decide if this falls into that category.
>>
>> I'll wait for opinions from others.
>
> No problem, I can also make it cheaper for servers to handle
> aborted connections in git-daemon:
>
> standalone:
>
>    1) use recv with MSG_PEEK or FIONREAD to determine if there's
>       readable data in the socket before forking (and avoid
>       forking for zero-bytes-written connections)
>
>    2) use TCP_DEFER_ACCEPT in Linux and dataready filter in FreeBSD
>       for standalone git-daemon to delay accept()
>
> inetd:
>
>    3) suppress die("The remote end hung up unexpectedly")
>       if no bytes are read at all
>
> At some point in the future, I would love to have git-daemon implement
> something like IDLE in IMAP (to avoid having clients poll for updates).
> Perhaps the standalone changes above would make sense there, too.

Before you submit a patch in that direction (or resubmit the patch under discussion here), could you please find someone to test your patch on Windows first? A lot of the infrastructure mentioned may not be available there or may not work as expected. (I admit that I'm just hand-waving, I haven't tested your patch.)

Thanks, -- Hannes

Previous: Eric WongNext: Junio C Hamano
Message 4 of 7 in “attempt connects in parallel for IPv6-capable builds”
  1. attempt connects in parallel for IPv6-capable buildsEric Wong, Jan 28, 2016
  2. Junio C HamanoJan 28, 2016
  3. Eric WongJan 29, 2016
  4. Johannes SixtJan 29, 2016
  5. Junio C HamanoJan 29, 2016
  6. Torsten BögershausenJan 29, 2016
  7. Eric WongJan 30, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.