Re: [PATCH 0/4] Submodule Groups

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Jan 21, 2016, 21:17 UTC
Message-ID: <56A14AD4.6040608@gmail.com>
In-Reply-To: <1453260880-628-1-git-send-email-sbeller@google.com>

On 20.01.2016 04:34, Stefan Beller wrote:

Show 7 quoted lines

> So you could have a .gitmodules file such as:
> 
> [submodule "gcc"]
>          path = gcc
>          url = git://...
>          groups = default
>          groups = devel

On the quick I was unable to find the rationale why entries are now stored as separated lines compared to v1. I liked the comma-separated approach better as it's more compact.

Anyway, if it's only one group per line, I'd find it more fitting to call the entry "group" instead of "groups" as it will always refer to a single group only. Also that would better match the "--group" command line option naming for "submodule add".

However, if I'd read the single line "group = default" in a .gitmodules file, it wouldn't be immediately clear to me that "group" can appear multiple times per submodule. "groups = default" would me more hinting is this regard because the plural is used, but without reading the docs I'd assume multiple groups would be specified like "groups = default,devel".

Long story short, my personal favorite still would be

[submodule "gcc"]
         groups = default,devel

followed by

[submodule "gcc"]
         group = default
         group = devel

-- 
Sebastian Schuberth