git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-gui: do not use obsolete `git merge $msg HEAD $branch'

From
Johannes Sixt <j6t@kdbg.org>
Date
Dec 16, 2015, 21:44 UTC
Message-ID
<5671DB28.8020901@kdbg.org>
Use the modern `git merge' invocation pattern.

Since both `git merge' and `git fmt-merge-msg' obey the merge.log configuration, instruct the former not to generate the log summary to avoid that it appears twice in the commit message.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 lib/merge.tcl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/merge.tcl b/lib/merge.tcl
index 460d32f..f512456 100644
--- a/lib/merge.tcl
+++ b/lib/merge.tcl
@@ -115,8 +115,9 @@ method _start {} {
 	set cmd [list git]
 	lappend cmd merge
 	lappend cmd --strategy=recursive
+	lappend cmd --no-log
+	lappend cmd -m
 	lappend cmd [git fmt-merge-msg <[gitdir FETCH_HEAD]]
-	lappend cmd HEAD
 	lappend cmd $name
 
 	ui_status [mc "Merging %s and %s..." $current_branch $stitle]
-- 
2.6.2.337.ga235d84
Message 1 of 1 in “git-gui: do not use obsolete `git merge $msg HEAD $branch'”
  1. git-gui: do not use obsolete `git merge $msg HEAD $branch'Johannes Sixt, Dec 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.