git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] dir: mark add_untracked_ident() as a file local symbol

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Dec 16, 2015, 16:06 UTC
Message-ID
<56718C1C.2040609@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Christian,

If you need to re-roll your 'cc/untracked' branch, could you please squash the relevant parts of this into your patches.

Thanks!

Also, you may what to consider removing the emulation of uname() on MinGW, since this is no longer required after your series.

ATB, Ramsay Jones

 dir.c | 2 +-
 dir.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/dir.c b/dir.c
index 94fba2a..be27afa 100644
--- a/dir.c
+++ b/dir.c
@@ -1908,7 +1908,7 @@ static int treat_leading_path(struct dir_struct *dir,
  * We used to save the location of the work tree and the kernel version,
  * but it was not a good idea, so we now just save an empty string.
  */
-void add_untracked_ident(struct untracked_cache *uc)
+static void add_untracked_ident(struct untracked_cache *uc)
 {
 	strbuf_addstr(&uc->ident, "");
 	/* this strbuf contains a list of strings, save NUL too */
diff --git a/dir.h b/dir.h
index 1935b76..531c99a 100644
--- a/dir.h
+++ b/dir.h
@@ -307,7 +307,6 @@ void untracked_cache_add_to_index(struct index_state *, const char *);
 void free_untracked_cache(struct untracked_cache *);
 struct untracked_cache *read_untracked_extension(const void *data, unsigned long sz);
 void write_untracked_extension(struct strbuf *out, struct untracked_cache *untracked);
-void add_untracked_ident(struct untracked_cache *);
 void add_untracked_cache(void);
 void remove_untracked_cache(void);
 #endif
-- 
2.6.0
Message 1 of 1 in “dir: mark add_untracked_ident() as a file local symbol”
  1. dir: mark add_untracked_ident() as a file local symbolRamsay Jones, Dec 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.