git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/2] test: factor out helper function test_must_contain

From
Johannes Sixt <j6t@kdbg.org>
Date
Nov 21, 2015, 08:11 UTC
Message-ID
<56502745.2000307@kdbg.org>
In-Reply-To
<564F8781.1080902@web.de>
Am 20.11.2015 um 21:50 schrieb René Scharfe:
> Extract a helper function for searching for a pattern in a file and
> printing the whole file if the pattern is not found.  It is useful
> when starting tests with --verbose for debugging purposes.
Show 11 quoted lines
> +# Check if a file contains an expected pattern.
> +test_must_contain () {
> +	if grep "$1" "$2"
> +	then
> +		return 0
> +	else
> +		echo "didn't find /$1/ in '$2', it contains:"
> +		cat "$2"
> +		return 1
> +	fi
> +}

There is already test_i18n_grep. Should it be folded into this function? Wouldn't we also want to have a function test_must_not_contain?

IMHO, we should not increase the number of functions that give a bonus only when there is a test case failure. They do not scale well: There is a permanent mental burden on every reviewer to watch out that they are used in new tests. But without those functions, the burden is on the one person investigating a test case failure, who has to live without the debugging support.

-- Hannes
Previous: René ScharfeNext: René Scharfe
Message 10 of 14 in “t1450: add tests for NUL in headers of commits and tags”
  1. 1/2 t1450: add tests for NUL in headers of commits and tagsRené Scharfe, Nov 19, 2015
  2. 2/2 fsck: treat a NUL in a tag header as an errorRené Scharfe, Nov 19, 2015
  3. Jeff KingNov 20, 2015
  4. Johannes SchindelinNov 20, 2015
  5. Eric SunshineNov 19, 2015
  6. René ScharfeNov 19, 2015
  7. Jeff KingNov 20, 2015
  8. René ScharfeNov 20, 2015
  9. 3/2 test: factor out helper function test_must_containRené Scharfe, Nov 20, 2015
  10. Johannes SixtNov 21, 2015
  11. René ScharfeNov 21, 2015
  12. 4/2 test: use test_must_containRené Scharfe, Nov 20, 2015
  13. SZEDER GáborNov 21, 2015
  14. René ScharfeNov 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.