Re: [PATCH] run-command: detect finished children by closed pipe rather than waitpid

From: Johannes Sixt <j6t@kdbg.org>
Date: Nov 11, 2015, 20:48 UTC
Message-ID: <5643A9A0.50105@kdbg.org>
In-Reply-To: <CAGZ79kaZ0W5q8=iowbSTJY_mDNNYc6qdTszcWDDDCtYfZyeK_Q@mail.gmail.com>

Am 11.11.2015 um 21:37 schrieb Stefan Beller:

Show 19 quoted lines

> including the list and all others this time.
>
>>>                          if (code < 0) {
>>>                                  pp->shutdown = 1;
>>> -                               kill_children(pp, SIGTERM);
>>> +                               kill_children(pp, -code);
>>
>>
>> I'll see what this means for our kill emulation on Windows. Currently, we
>> handle only SIGTERM.
>
> So currently we only pass in SIGTERM from the callers, and I certainly
> only intend
> to use that signal. I just thought special casing the SIGTERM signal
> would do no good
> in terms of design here.
>
> So maybe that was not the right thought and we do have to special case
> SIGTERM here?

I wonder why task_finish() callback gets to choose a signal. The point here is, IIUC, when one child dies, the others must be halted, too. SIGTERM seems to be the only sensible choice.

-- Hannes