Re: Allow git alias to override existing Git commands

From: Jens Lehmann <jens.lehmann@web.de>
Date: Nov 10, 2015, 21:57 UTC
Message-ID: <5642685F.9070405@web.de>
In-Reply-To: <CAGZ79kZxQWVMe3N1ti8npyp9_4DUPAVy9Uk5a75Jwh3Eud2eZQ@mail.gmail.com>

Am 10.11.2015 um 19:12 schrieb Stefan Beller:

Show 8 quoted lines

> On Tue, Nov 10, 2015 at 8:31 AM, Jeremy Morton <admin@game-point.net> wrote:
>> It's recently come to my attention that the "git alias" config functionality
>> ignores all aliases that would override existing Git commands.  This seems
>> like a bad idea to me.
>
> This ensures that the plumbing commands always work as expected.
> As scripts *should* only use plumbing commands, the scripts should
> work with high probability despite all the crazy user configuration/aliases.

Exactly.

Show 13 quoted lines

>> For example, I wanted to setup "git clone" to automatically act as "git
>> clone --recursive".  Sure I could do it in the shell, but it's more of a
>> pain - any tutorial I set up about doing it would have to worry about what
>> shell the user was using - and if you're going to make that argument, why
>> have "git alias" at all?  It can all be done from the shell.
>
> I think the git way for your example would be to configure git to include that
> option by default, something like
>
>      git config --global submodules.recursiveClone yes
>
> though I was skimming through the man page of git config and did not find
> that option there. I guess it's missing.

We thought about adding such a config option, but I believe that would fall a bit short. If I want to have recursive clone I also want to init all those submodules appearing in later fetches too (otherwise the end result would depend on whether you cloned before or after a submodule was added upstream, which is confusing). Extra points for populating the submodule in my work tree when switching to a commit containing the new submodule.

So what about a "submodule.autoupdate" config option? If set to true, all submodules not marked "update=none" would automatically be fetched and inited by fetch (and thus clone too) and then checked out (with my recursive update changes) in every work tree manipulating command (again including clone).

Users who only want the submodules to be present in the work tree but not automagically updated could set "submodule.autoupdate=clone" to avoid the extra cost of updating the work tree every time they switch between commits. Now that Heiko's config-from-commit changes are in master, someone could easily add that to fetch and clone as the first step. We could also teach clone to make "submodule.autoupdate=true" imply --recursive and execute the "git submodule" command to update the work tree as a first step until the recursive checkout patches are ready.

Does that make sense?