Re: [PATCH v7 01/11] refs: make is_branch public

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Nov 10, 2015, 07:37 UTC
Message-ID: <56419EBF.5020404@alum.mit.edu>
In-Reply-To: <5640EBD3.8040505@ramsayjones.plus.com>

On 11/09/2015 07:54 PM, Ramsay Jones wrote:

Show 20 quoted lines

> On 09/11/15 17:03, Michael Haggerty wrote:
>> [...]
>> diff --git a/refs.h b/refs.h
>> index 6d30c98..39b8edc 100644
>> --- a/refs.h
>> +++ b/refs.h
>> @@ -217,6 +217,8 @@ extern void warn_dangling_symrefs(FILE *fp, const char *msg_fmt, const struct st
>>   */
>>  int pack_refs(unsigned int flags);
>>  
>> +int is_branch(const char *refname);
>> +
>>  /*
>>   * Flags controlling ref_transaction_update(), ref_transaction_create(), etc.
>>   * REF_NODEREF: act on the ref directly, instead of dereferencing
>>
> 
> I don't understand, is_branch() is already declared in refs.h, see line 67.
> 
> This is true in master, next and pu now appears to have two declarations.

Thanks for noticing! I'll drop that patch from the next round.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu