Re: Bug: t5813 failing on Cygwin

From: Torsten Bögershausen <tboegi@web.de>
Date: Nov 8, 2015, 07:11 UTC
Message-ID: <563EF5B9.9020002@web.de>
In-Reply-To: <1446939168.16957.11.camel@kaarsemaker.net>

Show 23 quoted lines

>>
>> diff --git a/connect.c b/connect.c
>> index 108f5ab..fc73cf9 100644
>> --- a/connect.c
>> +++ b/connect.c
>> @@ -636,6 +636,8 @@ static enum protocol parse_connect_url(const char
>> *url_orig, char **ret_host,
>>  	end = path; /* Need to \0 terminate host here */
>>  	if (separator == ':')
>>  		path++; /* path starts after ':' */
>> +	if (starts_with(path, "//"))
>> +		path++;
>>  	if (protocol == PROTO_GIT || protocol == PROTO_SSH) {
>>  		if (path[1] == '~')
>>  			path++;
>>
>> It seems to work, but I haven't thought about it too deeply ...
>> so I don't know if there are any problems lurking. :)
>>
>> I have to go now, so if somebody wants to take this up ...
> 
> Won't that break file:////server/share urls on cygwin?
>

The official way to specify UNC names looks like this: file://<host>/<path> (Or file://server/share/morepath to follow your example) #http://www.faqs.org/rfcs/rfc1738.html

But unfortunately Git doesn't support it. I can put it on the to-do list...

But using "file:////" this is not an official syntax, and should (in theory) not be used by any user. Does anybody use it?

Or do people use simply "git clone //server/share/" ?