Re: [PATCH 1/2] run-command: factor out child_process_clear()

From: René Scharfe <l.s.r@web.de>
Date: Oct 27, 2015, 21:29 UTC
Message-ID: <562FECCA.6080703@web.de>
In-Reply-To: <CAGZ79kYopHL5D_7+bJV2P9GeKDHufPDBTo3a8bRL=4B3OmTGjg@mail.gmail.com>

Am 26.10.2015 um 20:23 schrieb Stefan Beller:

Show 14 quoted lines

> On Mon, Oct 26, 2015 at 11:43 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> René Scharfe <l.s.r@web.de> writes:
>>
>>> Avoid duplication by moving the code to release allocated memory for
>>> arguments and environment to its own function, child_process_clear().
>>> Export it to provide a counterpart to child_process_init().
>>>
>>> Signed-off-by: Rene Scharfe <l.s.r@web.de>
>>> ---
>>
>> Hmm, is this _deinit() Stefan added to his series recently?
>
> Yes. Although you (Junio) take credit for actually using it in these
> places, too. :)

Oh, and it's already in next. I still like _clear() better (as in {argv,object,ref,sha1}_array_clear(), or string_list_clear(), or ...) than _deinit(), which seems to have been introduced by vcs-svn and isn't a real word. I'll rebase my patches on top of this series, but probably not before the weekend.

René