Re: [PATCH v1] convert: display progress for filtered objects that have been delayed

From: Lars Schneider <larsxschneider@gmail.com>
Date: Oct 4, 2017, 13:33 UTC
Message-ID: <5625E29A-D24F-4A5F-AA52-58F2EBCA9648@gmail.com>
In-Reply-To: <xmqqr2uj9lfk.fsf@gitster.mtv.corp.google.com>

Show 21 quoted lines

> On 04 Oct 2017, at 13:55, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>>> The delayed progress API is being simplified so I'll probably do a
>>> bit of evil merge while merging this to 'pu'.
>> 
>> I just realized that this patch got lost :-(
> 
> Really?  Isn't it 52f1d62e ("convert: display progress for filtered
> objects that have been delayed", 2017-08-20)?  It already is in
> 'master' since about 3 weeks ago.
> 
> As this is merely a new "feature", I do not think it is reasonable
> to expect it to be merged down to 'maint'.  In fact, I think your
> original patch <20170820154720.32259-1-larsxschneider@gmail.com>
> declared that its Base Ref was "master", and I queued the topic on
> top of the then-current 'master', so it is not mergeable to 'maint'.
> 
> It may be cherry-pickable, but I do not think it deserves to be.  It
> is not a fix for a grave bug or anything like that, right?

The original topic 2841e8f ("convert: add "status=delayed" to filter process protocol", 2017-06-30) is a new feature. That's why I was surprised to see it in 2.14.2! The problem is that this topic might appear "broken" to the user without the progress output introduce in 52f1d62e ("convert: display progress for filtered objects that have been delayed", 2017-08-20).

In summary: 2841e8f was merged to 2.14.2 and 52f1d62e was not. Therefore, it would be great to have 52f1d62e in 2.14.3. Does this sound reasonable to you?

Thanks, Lars