git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git feature request: mark a commit as minor

From
Felipe Micaroni Lalli <micaroni@walltime.info>
Date
Oct 3, 2015, 06:44 UTC
Message-ID
<560F794F.2010809@walltime.info>
In-Reply-To
<CAHYJk3Qb89YhVJoOpBLYMoNJX5GvVHnJhf41Gdbtypcp+Yq96g@mail.gmail.com>
Thank you Jacob.
Actually we already use the keyword MINOR for that, exactly as you said.

The suggestion was made because I think it is a common behavior and it would be nice to be a meta info to standardize this (today each team adopt a different pattern for that - you used "TRIVIAL" e.g.). Nice things could be done with this meta-info. It could be totally ignored (current git operation) or it could be used to filter, to sort, to group commits, to show the log pretty etc.

> The issue is that not everyone considers these changes as "minor".

I understand this issue, I know it is subjective. But if someone don't want to make the distinction just don't use the argument --hide-minor for example.

On 03/10/2015 03:17, Mikael Magnusson wrote:
Show 26 quoted lines
> On Sat, Oct 3, 2015 at 8:11 AM, Jacob Keller <jacob.keller@gmail.com> wrote:
>> On Fri, Oct 2, 2015 at 2:38 PM, Felipe Micaroni Lalli
>> <micaroni@walltime.info> wrote:
>>> A minor change (also called "cosmetic") usually is a typo fix, doc
>>> improvement, a little code refactoring that don't change the behavior etc.
>>>
>>> In Wikipedia we can mark an edition as "minor".
>>>
>>> It would be nice to have an argument like "--minor" in git-commit to
>>> mark the commit as minor. Also, filter in git-log (like --hide-minor) to
>>> hide the minor changes. The git-log could be optimized to show minor
>>> commits more discreetly.
>>>
>>>
>>
>> This should just be part of the commit message log, generally projects
>> use something like TRIVIAL in the patch subject or similar. You could
>> also standardize for your project(s) what would be considered a minor
>> change. The issue is that not everyone considers these changes as
>> "minor". You should be able to use a combination of the --grep option
>> in log to search for all commits who don't contain that string in the
>> right format.
> 
> Could also be a good use for notes, since you might want to add this
> markup after the fact.
>
Previous: Mikael MagnussonNext: Jacob Keller
Message 4 of 7 in “Git feature request: mark a commit as minor”
  1. Felipe Micaroni LalliOct 2, 2015
  2. Jacob KellerOct 3, 2015
  3. Mikael MagnussonOct 3, 2015
  4. Felipe Micaroni LalliOct 3, 2015
  5. Jacob KellerOct 4, 2015
  6. Fredrik GustafssonOct 3, 2015
  7. Felipe Micaroni LalliOct 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.